Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Mask sensitive fields when reading container registry via the manager GQL API #1627

Merged
merged 6 commits into from
Oct 24, 2023
Merged

fix: Mask sensitive fields when reading container registry via the manager GQL API #1627

merged 6 commits into from
Oct 24, 2023

Conversation

achimnol
Copy link
Member

@achimnol achimnol commented Oct 18, 2023 •
edited
Loading

refs #1626

  • fix: Mask container registry passwords from the GQL-based CRUD APIs
  • doc: Add news fragment

BREAKING CHANGE

  • Let's retire /config/get and /config/set APIs (delayed for a follow-up PR)

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version
  • Mention to the original issue
  • API server-client counterparts (e.g., manager API -> client SDK)

@achimnol achimnol added this to the 23.03 milestone Oct 18, 2023
@achimnol achimnol added type:bug Reports about that are not working comp:manager Related to Manager component labels Oct 18, 2023
@achimnol achimnol self-assigned this Oct 18, 2023
@achimnol achimnol requested a review from adrysn October 18, 2023 03:49
@github-actions github-actions bot added the size:XS ~10 LoC label Oct 18, 2023
@achimnol achimnol changed the title fix: Mask sensitive fields when reading configs via the manager API fix: Mask sensitive fields when reading container registry via the manager GQL API Oct 24, 2023
@github-actions github-actions bot added the urgency:5 It is imperative that action be taken right away. label Oct 24, 2023
@achimnol achimnol enabled auto-merge October 24, 2023 06:55
@achimnol achimnol mentioned this pull request Oct 24, 2023
Closed
@achimnol achimnol added this pull request to the merge queue Oct 24, 2023
Merged via the queue into main with commit b45ad45 Oct 24, 2023
18 checks passed
@achimnol achimnol deleted the fix/mask-sensitive-fields-in-config-api branch October 24, 2023 07:02
achimnol added a commit that referenced this pull request Oct 24, 2023
@achimnol
fix: Mask sensitive fields when reading container registry via the ma…
398f64b 
…nager GQL API (#1627)

Backported-from: main
Backported-to: 23.09
achimnol added a commit that referenced this pull request Oct 24, 2023
@achimnol
fix: Mask sensitive fields when reading container registry via the ma…
9dfe9c7 
…nager GQL API (#1627)

Backported-from: main
Backported-to: 23.03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrysn adrysn Awaiting requested review from adrysn

Assignees

@achimnol achimnol

Labels
comp:manager Related to Manager component size:XS ~10 LoC type:bug Reports about that are not working urgency:5 It is imperative that action be taken right away.
Projects
None yet
Milestone
23.03
Development

Successfully merging this pull request may close these issues.
1 participant
@achimnol