fix: replace stream connection API key from kernel id to session id #1622
+401
−323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
comp:manager
- It is better to cast the ID columns using explicit constructor of the subtype. - The stream key is now based on session IDs, but still the callback's partial arguments are only kernel IDs. This may confuse future code readers. - As of Python 3.8, `functools.partial()` now has correct type inference and support for async functions.
achimnol
requested changes
Oct 16, 2023
src/ai/backend/manager/api/stream.py
Outdated
Comment on lines
469
to
472
| stream_key = session_id | ||
| stream_id = uuid.uuid4().hex | ||
| app_ctx.stream_proxy_handlers[stream_key].add(myself) | ||
| defer(lambda: app_ctx.stream_proxy_handlers[stream_key].discard(myself)) | ||
| app_ctx.stream_proxy_handlers[kernel_id].add(myself) | ||
| defer(lambda: app_ctx.stream_proxy_handlers[kernel_id].discard(myself)) |
There was a problem hiding this comment.
stream_proxy_handlers in other places (e.g., handle_kernel_terminating()) still uses kernel.id as the stream key. We should make the naming of stream_key consistent in two different usage scenarios in this module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow-up #576
Change a key of session connection info from
session_idtokernel_idChecklist: (if applicable)