-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add SSL Support for Redis and Redis Sentinel Connections #1605
base: main
Are you sure you want to change the base?
Conversation
0fdbaf3
to
9644099
Compare
This PR stores the certificate files in the ./volumes/redis-data directory, so make sure you have sufficient permissions on that path. Otherwise, you will get Error 13 when connecting Redis (permission denied) |
@jopemachine Due to #1620, it requires merge-conflict resolution. Please update the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR stores the certificate files in the ./volumes/redis-data directory, so make sure you have sufficient permissions on that path. Otherwise, you will get Error 13 when connecting Redis (permission denied)
They should be moved to the fixtures
directory. volumes
should be left as owned by the halfstack containers and the container engine. Do not put anything there that are not created and managed by halfstack containers.
9644099
to
ab0bece
Compare
Thanks for letting me know! I updated the PR. |
Currently we are considering rewriting of |
I will mark this PR as draft cause this is on hold |
A follow-up to #1586.
Add support for SSL/TLS encryption for Redis and Redis sentinel connections. It introduces a new option
--enable-ssl
in theinstall-dev.sh
script, modifies the configuration files and the docker-compose files, and updates theredis_helper
module and the related files.