Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing UUID conversion when accepting vfolder "name or ID" in the vfolder REST APIs #3450

Open
achimnol opened this issue Jan 14, 2025 — with Lablup-Issue-Syncer · 0 comments · May be fixed by #3451
Open

Missing UUID conversion when accepting vfolder "name or ID" in the vfolder REST APIs #3450

achimnol opened this issue Jan 14, 2025 — with Lablup-Issue-Syncer · 0 comments · May be fixed by #3451
Assignees

Comments

@achimnol
Copy link
Member

Summary  

The intention of resolve_vfolder_rows() in the manager.api.vfolder module is to accept either an UUID or a human-friendly vfolder name. However, the primary caller, @with_vfolder_rows_resolved decorator did not try to convert the match-info value to UUID and has always passed it as str.

The result is that even the client places UUID in the vfolder REST APIs (/folders/{here}/...), it was always interpreted as vfolder names, not IDs.

We had a plan to add a new set of vfolder REST APIs as /folder/{id}/..., but I think we can just embrace the ID-based queries by fixing @with_vfolder_rows_resolved to work as originally intended.

@achimnol achimnol self-assigned this Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant