feat: aiohttp-3.9.1 update (#1855)

changes/1855.misc.md

@@ -0,0 +1 @@
+Update aiohttp to 3.9.1 and workaround mypy `TCPConnector` ssl keyword argument type by add custom type `SSLContextType` 

requirements.txt

@@ -1,11 +1,11 @@
 aiodataloader-ng~=0.2.1
 aiodocker~=0.21.0
 aiofiles~=0.8.0
-aiohttp~=3.8.1
+aiohttp~=3.9.1
 aiohttp_cors~=0.7
 aiohttp_sse>=2.0
 aiodns>=3.0
-aiomonitor~=0.6.0
+aiomonitor~=0.7.0
 aioresponses>=0.7.3
 aiosqlite~=0.17.0
 aiotools~=1.7.0

src/ai/backend/client/session.py

@@ -33,6 +33,7 @@
     "api_session",
 )
 
+from ..common.types import SSLContextType
 
 api_session: ContextVar[BaseSession] = ContextVar("api_session")
 
@@ -408,7 +409,7 @@ def __init__(
         self._worker_thread.start()
 
         async def _create_aiohttp_session() -> aiohttp.ClientSession:
-            ssl = None
+            ssl: SSLContextType = None
             if self._config.skip_sslcert_validation:
                 ssl = False
             connector = aiohttp.TCPConnector(ssl=ssl)
@@ -479,7 +480,7 @@ def __init__(
         proxy_mode: bool = False,
     ) -> None:
         super().__init__(config=config, proxy_mode=proxy_mode)
-        ssl = None
+        ssl: SSLContextType = None
         if self._config.skip_sslcert_validation:
             ssl = False
         connector = aiohttp.TCPConnector(ssl=ssl)

src/ai/backend/common/types.py

@@ -15,6 +15,7 @@
 from decimal import Decimal
 from ipaddress import ip_address, ip_network
 from pathlib import PurePosixPath
+from ssl import SSLContext
 from typing import (
     TYPE_CHECKING,
     Any,
@@ -41,6 +42,7 @@
 import redis.asyncio.sentinel
 import trafaret as t
 import typeguard
+from aiohttp import Fingerprint
 from redis.asyncio import Redis
 
 from .exception import InvalidIpAddressValue
@@ -1181,6 +1183,8 @@ def as_trafaret(cls) -> t.Trafaret:
 # States of the round-robin scheduler for each resource group and architecture.
 RoundRobinStates: TypeAlias = dict[str, dict[str, RoundRobinState]]
 
+SSLContextType: TypeAlias = Literal[False] | Fingerprint | SSLContext | None
+
 
 class ModelServiceStatus(enum.Enum):
     HEALTHY = "healthy"

src/ai/backend/manager/container_registry/base.py

@@ -20,6 +20,7 @@
 from ai.backend.common.exception import InvalidImageName, InvalidImageTag
 from ai.backend.common.logging import BraceStyleAdapter
 
+from ...common.types import SSLContextType
 from ..models.image import ImageRow, ImageType
 from ..models.utils import ExtendedAsyncSAEngine
 
@@ -70,7 +71,7 @@ def __init__(
 
     @actxmgr
     async def prepare_client_session(self) -> AsyncIterator[tuple[yarl.URL, aiohttp.ClientSession]]:
-        ssl_ctx = None  # default
+        ssl_ctx: SSLContextType = None  # default
         if not self.registry_info["ssl_verify"]:
             ssl_ctx = False
         connector = aiohttp.TCPConnector(ssl=ssl_ctx)