Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Install MetaMask page and don't require signature on dydx #519

Merged
merged 9 commits into from
Oct 18, 2024

Conversation

adamiak
Copy link
Member

@adamiak adamiak commented Oct 8, 2024

Resolves L2B-7576

Copy link

linear bot commented Oct 8, 2024

@adamiak adamiak changed the title Add Install MetaMask page Add Install MetaMask page and don't require signature on dydx Oct 16, 2024
@adamiak adamiak marked this pull request as ready for review October 16, 2024 14:35
Comment on lines 527 to 530
router.get('/tos', async (ctx) => {
const givenUser = getGivenUser(ctx)
const result = await staticPageController.getTermsOfServicePage(givenUser)
applyControllerResult(ctx, result)
})

router.get('/metamask-required', async (ctx) => {
const givenUser = getGivenUser(ctx)
const result = await staticPageController.getInstallMetaMaskPage(givenUser)
applyControllerResult(ctx, result)
})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why removed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge error, fixed.

@adamiak adamiak added this pull request to the merge queue Oct 18, 2024
Merged via the queue into master with commit a7edd0b Oct 18, 2024
4 checks passed
@adamiak adamiak deleted the add-install-metamask-page branch October 18, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants