Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing escape hatch tests #450

Merged
merged 11 commits into from
Aug 3, 2023
Merged

Conversation

adamiak
Copy link
Member

@adamiak adamiak commented Jul 31, 2023

Resolves L2B-1934

@adamiak adamiak changed the title Add test to StateUpdateRepository Add missing escape hatch tests Jul 31, 2023
@linear
Copy link

linear bot commented Aug 2, 2023

L2B-1934 Add missing unit tests

To accelerate merge of PR #421 a few modifications miss unit test. It is essential to add these unit tests before project is finalaised. Here's a list of files that have new functionality not covered by unit tests. Add them:

  • packages/backend/src/peripherals/database/StateUpdateRepository.ts
  • packages/backend/src/core/FreezeCheckService.ts
  • packages/backend/src/api/controllers/UserController.ts
  • packages/backend/src/api/controllers/getEscapableAssets.ts
  • packages/backend/src/api/controllers/serializeMerkleProofForEscape.ts
  • packages/state/src/MerkleTree.ts
  • packages/state/src/PositionLeaf.ts
  • packages/backend/src/peripherals/ethereum/EthereumClient.ts
  • packages/encoding/src/encoding/encodeState.ts

@adamiak adamiak marked this pull request as ready for review August 2, 2023 21:05
@adamiak adamiak requested a review from torztomasz August 2, 2023 21:05
@adamiak adamiak enabled auto-merge August 2, 2023 21:05
@adamiak adamiak added this pull request to the merge queue Aug 3, 2023
Merged via the queue into master with commit 08893a6 Aug 3, 2023
4 checks passed
@adamiak adamiak deleted the add-missing-escape-unittests branch August 3, 2023 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants