Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle withdrawal with eth address #430

Merged
merged 1 commit into from
Jul 25, 2023
Merged

Conversation

torztomasz
Copy link
Contributor

Resolves L2B-795

@linear
Copy link

linear bot commented Jul 20, 2023

L2B-795 Handle vaults that use EthereumAddress as StarkKey

On the new Spot StarkEx (and Perpetual v2!!! like Apex?!), assets ready for withdrawal are transferred to a special vault which is assigned to StarkKey that is actually a lot of zeros and an Ethereum address. See this link for details:

<https://docs.starkware.co/starkex/spot/withdrawal.html>

See point 2.

Research if we are handling this correctly. Some idea:

  • when displaying user page, we should also check for assets in the vault corresponding to their registered address, otherwise quick actions won't show!?
  • as above, we won't be showing regular withdrawals as they are happening on the other vault

Notes:

Use testnet to check how it all works: https://testnet.pro.apex.exchange/trade/

@torztomasz torztomasz temporarily deployed to apex-explorer July 21, 2023 07:22 Inactive
@torztomasz torztomasz force-pushed the handle-withdrawal-to-address branch from dc5c22a to 4991527 Compare July 21, 2023 07:43
@torztomasz torztomasz temporarily deployed to apex-explorer July 21, 2023 07:43 Inactive
@torztomasz torztomasz marked this pull request as ready for review July 21, 2023 08:24
@torztomasz torztomasz added this pull request to the merge queue Jul 25, 2023
Merged via the queue into master with commit d760903 Jul 25, 2023
4 checks passed
@torztomasz torztomasz deleted the handle-withdrawal-to-address branch July 25, 2023 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants