Add eslint rule for unnecessary backticks (#470)

l2beat · Aug 18, 2023 · 05de3f2 · 05de3f2
1 parent d49c8e4
commit 05de3f2
Show file tree

Hide file tree

Showing 12 changed files with 17 additions and 12 deletions.
diff --git a/.eslintrc.json b/.eslintrc.json
@@ -19,6 +19,11 @@
   },
   "plugins": ["simple-import-sort", "no-only-tests", "unused-imports"],
   "rules": {
+    "quotes": [
+      "error",
+      "single",
+      { "avoidEscape": true, "allowTemplateLiterals": false }
+    ],
     "@typescript-eslint/ban-tslint-comment": "off",
     "@typescript-eslint/explicit-module-boundary-types": "off",
     "@typescript-eslint/no-extra-semi": "off",

diff --git a/packages/backend/src/api/controllers/ForcedTradeOfferController.test.ts b/packages/backend/src/api/controllers/ForcedTradeOfferController.test.ts
@@ -499,7 +499,7 @@ describe(ForcedTradeOfferController.name, () => {
 
       expect(await controller.cancelOffer(1, '123')).toEqual({
         type: 'not found',
-        message: `Offer #1 does not exist`,
+        message: 'Offer #1 does not exist',
       })
     })
 

diff --git a/packages/backend/src/api/controllers/TransactionSubmitController.ts b/packages/backend/src/api/controllers/TransactionSubmitController.ts
@@ -146,7 +146,7 @@ export class TransactionSubmitController {
       return fetched.controllerResult
     }
     if (!tradeMatchesOffer(offer, fetched.data)) {
-      return { type: 'bad request', message: `Trade does not match offer` }
+      return { type: 'bad request', message: 'Trade does not match offer' }
     }
 
     // TODO: cross repository transaction

diff --git a/packages/backend/src/core/FreezeCheckService.ts b/packages/backend/src/core/FreezeCheckService.ts
@@ -86,12 +86,12 @@ export class FreezeCheckService {
         'function FREEZE_GRACE_PERIOD() view returns (uint256)'
       )
     if (err) {
-      this.logger.error(`Failed calling FREEZE_GRACE_PERIOD()`)
+      this.logger.error('Failed calling FREEZE_GRACE_PERIOD()')
       throw err
     }
     if (freezeGracePeriod === undefined) {
       throw new Error(
-        `Failed calling FREEZE_GRACE_PERIOD(): received undefined`
+        'Failed calling FREEZE_GRACE_PERIOD(): received undefined'
       )
     }
     return freezeGracePeriod.toNumber()

diff --git a/packages/backend/src/core/TransactionHistory.test.ts b/packages/backend/src/core/TransactionHistory.test.ts
@@ -234,7 +234,7 @@ describe(TransactionHistory.name, () => {
         )
       })
 
-      it(`returns [INCLUDED, ...previousRegularTransactionHistoryResults] if userTransaction is included`, () => {
+      it('returns [INCLUDED, ...previousRegularTransactionHistoryResults] if userTransaction is included', () => {
         const forcedTradeOffer = fakeOffer()
         const sentTransaction = fakeSentTransaction()
         const userTransaction = fakeUserTransaction({

diff --git a/packages/backend/src/core/TransactionValidator.ts b/packages/backend/src/core/TransactionValidator.ts
@@ -35,7 +35,7 @@ export class TransactionValidator {
         isSuccess: false,
         controllerResult: {
           type: 'bad request',
-          message: `Invalid transaction`,
+          message: 'Invalid transaction',
         },
       }
     }

diff --git a/packages/backend/src/core/collectors/AssetRegistrationCollector.ts b/packages/backend/src/core/collectors/AssetRegistrationCollector.ts
@@ -13,7 +13,7 @@ import { LogTokenRegistered } from './events'
 const ETH_SELECTOR = '0x8322fff2'
 const ERC20_SELECTOR = '0xf47261b0'
 const ERC721_SELECTOR = '0x02571792'
-const ERC1155_SELECTOR = `0x3348691d`
+const ERC1155_SELECTOR = '0x3348691d'
 const MINTABLE_ERC721_SELECTOR = '0xb8b86672'
 const MINTABLE_ERC20_SELECTOR = '0x68646e2d'
 

diff --git a/packages/backend/src/core/collectors/FeederGatewayCollector.ts b/packages/backend/src/core/collectors/FeederGatewayCollector.ts
@@ -52,7 +52,7 @@ export class FeederGatewayCollector {
       throw new Error(`State update ${stateUpdateId} not found`)
     }
 
-    this.logger.info(`Collecting transactions from Feeder Gateway`, {
+    this.logger.info('Collecting transactions from Feeder Gateway', {
       stateUpdateId: stateUpdate.id,
     })
 

diff --git a/packages/encoding/src/encoding/encodeState.test.ts b/packages/encoding/src/encoding/encodeState.test.ts
@@ -28,7 +28,7 @@ describe(encodeStateAsInt256Array.name, () => {
     // encodeState is tested in encodeOnchainData.test.ts
   })
 
-  it(`properly serialized state`, () => {
+  it('properly serialized state', () => {
     const result = encodeStateAsInt256Array(newState)
     expect(result).toEqual([
       4855295734011000137694901532041540081493925748614200896918173841152119144448n,

diff --git a/...end/src/view/components/tables/l2-transactions/perpetual/PerpetualL2TransactionsTable.tsx b/...end/src/view/components/tables/l2-transactions/perpetual/PerpetualL2TransactionsTable.tsx
@@ -27,7 +27,7 @@ export function PerpetualL2TransactionsTable(
   props: PerpetualL2TransactionsTableProps
 ) {
   const columns: Column[] = [
-    { header: `ID` },
+    { header: 'ID' },
     { header: 'Type' },
     { header: 'Status' },
     { header: 'Age' },

diff --git a/packages/shared/src/old/FinalizeExitData.ts b/packages/shared/src/old/FinalizeExitData.ts
@@ -9,7 +9,7 @@ export function encodeFinalizeExitRequest(starkKey: StarkKey) {
   return coder.encodeFunctionData('withdraw', [
     starkKey.toString(),
     //hardcoded just because it will take time to pass collateral asset to this function and it is going to be removed soon
-    `0x02893294412a4c8f915f75892b395ebbf6859ec246ec365c3b1f56f47c3a0a5d`,
+    '0x02893294412a4c8f915f75892b395ebbf6859ec246ec365c3b1f56f47c3a0a5d',
   ])
 }
 

diff --git a/packages/shared/src/toSignableCancelOffer.test.ts b/packages/shared/src/toSignableCancelOffer.test.ts
@@ -5,7 +5,7 @@ import { toSignableCancelOffer } from './toSignableCancelOffer'
 describe(toSignableCancelOffer.name, () => {
   it('works properly', () => {
     expect(toSignableCancelOffer(1)).toEqual(
-      ['{', `  "cancel": true,`, `  "offerId": 1`, '}'].join('\n')
+      ['{', '  "cancel": true,', '  "offerId": 1', '}'].join('\n')
     )
   })
 })