Modularize discovery #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
L2B-2528 Create abstraction to define modules
Make a factory method that depends on chain-specific config. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
michalsidzej
approved these changes
Sep 26, 2023
|
|
||
| export class ClockIndexer extends RootIndexer { | ||
| constructor( | ||
| logger: Logger, | ||
| // Just for pretty logging purposes | ||
| chainId: ChainId, | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves L2B-2528
What's changed
Now to support new EVM-compatbile chain monitoring you have to create backend config within
discovery.modules. Key must match valid chain names. Also, discovery config must be present for the given chain.Abstraction is straightforward as long as we only work on similar Ethereum-like configs. In the future we will probably plan to refactor it a bit to support more sophisticated configurations and chains
Also added optimism using new modular way - easy as hell