Improve mobile view #102
Merged
Improve mobile view #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
sdlyy
requested changes
Dec 18, 2023
Comment on lines
89
to
97
| <TransactionProperty | ||
| param="Transaction hash" | ||
| value={ | ||
| <TransactionHash | ||
| transactionHash={transaction.transactionHash} | ||
| noStyle | ||
| /> | ||
| } | ||
| /> |
There was a problem hiding this comment.
If the transaction has not been executed, the transaction hash will be null thus crashing frontend since we have no error boundaries
There was a problem hiding this comment.
To reproduce please choose any discarded transaction of your liking and try to expand it
There was a problem hiding this comment.
Yet again safe api kit typings are wrong, I'll submit a fix soonish ;p
| @@ -40,7 +40,7 @@ export function RowLabel({ | |||
| return ( | |||
| <div | |||
| className={cx( | |||
| 'py-2 pr-2 text-sm font-medium leading-5 text-gray-100 md:w-1/5 md:py-0', | |||
| 'py-2 pr-2 text-sm font-medium leading-5 text-zinc-200 md:w-1/5 md:py-0', | |||
| widthRation, | |||
There was a problem hiding this comment.
I see I made typo back then, could you please fix it?
widthRation => widthRatio
thx ❗
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves L2B-3174