Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add foundry support #63

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add foundry support #63

wants to merge 2 commits into from

Conversation

0xnonso
Copy link

@0xnonso 0xnonso commented Oct 13, 2023

Closes #60

@vercel
Copy link

vercel bot commented Oct 13, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
byor-wallet ✅ Ready (Inspect) Visit Preview Jan 21, 2024 4:32pm

mateuszradomski
mateuszradomski requested changes Oct 16, 2023
View reviewed changes
Copy link
Collaborator

@mateuszradomski mateuszradomski left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello,

Great start and I admire the courage to try and combine Hardhat and Foundry at the same time. But it's going to be easier to just drop Hardhat and support Foundry only. I've left some comments that coordinate this move plus that remove some unneeded files. Make sure to take a look at our CI, what it tests and how to make it pass. Also, please create a README.md in the contracts package to list all the possible things we would want to do and how to do them:

  • how to test
  • how to deploy
  • how to extend
  • how to build/typecheck

If you have any questions you're always welcome on our Discord (link is in the issue) :+]

packages/contracts/.env.example Outdated Show resolved Hide resolved
packages/contracts/.github/workflows/test.yml Outdated Show resolved Hide resolved
packages/contracts/package.json Outdated Show resolved Hide resolved
packages/contracts/hardhat.config.ts Outdated Show resolved Hide resolved
@0xnonso
Copy link
Author

0xnonso commented Oct 25, 2023

typescript check and linting wont be required, is it ok to remove and replace with just sol linting?

@mateuszradomski
Copy link
Collaborator

typescript check and linting wont be required, is it ok to remove and replace with just sol linting?

yep, as long as the lint CI passes everything is fine :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mateuszradomski mateuszradomski mateuszradomski requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate the contracts package to Foundry
2 participants
@0xnonso @mateuszradomski