Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: backend requests in safari #3425

Merged
merged 1 commit into from
Oct 21, 2024
Merged

fix: backend requests in safari #3425

merged 1 commit into from
Oct 21, 2024

Conversation

chriskari
Copy link
Contributor

@chriskari chriskari commented Oct 21, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • remove linebreak character at end of url paths in safari

Related issue(s)
#3411

Definition of done

  • The PR's title starts with one of the following prefixes:
    • feat: A new feature
    • fix: A bug fix
    • docs: Documentation only changes
    • refactor: A code change that neither fixes a bug nor adds a feature
    • test: Adding tests
    • chore: Maintainance changes to the build process or auxiliary tools, libraries, workflows, etc.
  • Related issues are linked. To link internal trackers, use the issue IDs like backlog#4567
  • Explain clearly why you created the PR and what changes it introduces
  • All necessary steps are delivered, for example, tests, documentation, merging

@chriskari chriskari linked an issue Oct 21, 2024 that may be closed by this pull request
Cannot open resource details on Safari #3411
Closed
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 21, 2024
@dbadura dbadura self-assigned this Oct 21, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Oct 21, 2024
@chriskari chriskari merged commit 435946a into kyma-project:main Oct 21, 2024
59 of 65 checks passed
@chriskari chriskari deleted the fix-safari branch October 22, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbadura dbadura dbadura approved these changes

@akucharska akucharska Awaiting requested review from akucharska akucharska is a code owner

@mrCherry97 mrCherry97 Awaiting requested review from mrCherry97 mrCherry97 is a code owner

@OliwiaGowor OliwiaGowor Awaiting requested review from OliwiaGowor OliwiaGowor is a code owner

Assignees

@dbadura dbadura

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot open resource details on Safari
3 participants
@chriskari @dbadura @kyma-bot