Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Update docs about busola-kyma image #3402

Merged
merged 4 commits into from
Oct 15, 2024
Merged

docs: Update docs about busola-kyma image #3402

merged 4 commits into from
Oct 15, 2024

Conversation

dbadura
Copy link
Contributor

@dbadura dbadura commented Oct 11, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • Add case with custom config and how to active it
  • Add case with how to active build-in config for kyma.

Related issue(s)
#3298

Definition of done

  • The PR's title starts with one of the following prefixes:
    • feat: A new feature
    • fix: A bug fix
    • docs: Documentation only changes
    • refactor: A code change that neither fixes a bug nor adds a feature
    • test: Adding tests
    • chore: Maintainance changes to the build process or auxiliary tools, libraries, workflows, etc.
  • Related issues are linked. To link internal trackers, use the issue IDs like backlog#4567
  • Explain clearly why you created the PR and what changes it introduces
  • All necessary steps are delivered, for example, tests, documentation, merging

@dbadura dbadura requested a review from a team as a code owner October 11, 2024 14:00
@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Oct 11, 2024
@dbadura dbadura changed the title chore: Update docs about busola-kyma image docs: Update docs about busola-kyma image Oct 11, 2024
@kyma-bot kyma-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 11, 2024
@dbadura dbadura mentioned this pull request Oct 11, 2024
Open
11 tasks
mrCherry97
mrCherry97 previously approved these changes Oct 15, 2024
View reviewed changes
@kyma-bot kyma-bot added the lgtm Looks good to me! label Oct 15, 2024
grego952
grego952 reviewed Oct 15, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@dbadura @grego952
Apply suggestions from code review
b8da4bf 
Co-authored-by: Grzegorz Karaluch <[email protected]>
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Oct 15, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Oct 15, 2024
@mrCherry97
Copy link
Contributor

/override tide

@kyma-bot
Copy link
Contributor

@mrCherry97: Overrode contexts on behalf of mrCherry97: tide

In response to this:

/override tide

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mrCherry97 mrCherry97 merged commit 53c1a5f into kyma-project:main Oct 15, 2024
6 checks passed
@dbadura dbadura deleted the update-readme branch October 15, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grego952 grego952 grego952 approved these changes

@mrCherry97 mrCherry97 mrCherry97 left review comments

Assignees

@mrCherry97 mrCherry97

@grego952 grego952

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dbadura @mrCherry97 @kyma-bot @grego952