-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify dropdowns #273
Merged
kyma-bot
merged 26 commits into
kyma-project:main
from
dariadomagala-sap:unify-dropdowns
Jul 15, 2021
Merged
Unify dropdowns #273
kyma-bot
merged 26 commits into
kyma-project:main
from
dariadomagala-sap:unify-dropdowns
Jul 15, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dariadomagala-sap
requested review from
akucharska,
parostatkiem-zz,
valentinvieriu and
Wawrzyn321
as code owners
July 7, 2021 12:26
kyma-bot
added
the
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
label
Jul 7, 2021
kyma-bot
added
size/XL
Denotes a PR that changes 500-999 lines, ignoring generated files.
and removed
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
labels
Jul 9, 2021
kyma-bot
added
size/XXL
Denotes a PR that changes 1000+ lines, ignoring generated files.
and removed
size/XL
Denotes a PR that changes 500-999 lines, ignoring generated files.
labels
Jul 13, 2021
akucharska
reviewed
Jul 15, 2021
core-ui/src/components/ApiRules/ApiRuleForm/AccessStrategyForm/AccessStrategyForm.js
Show resolved
Hide resolved
core-ui/src/components/ApiRules/ApiRuleForm/AccessStrategyForm/test/AccessStrategyForm.test.js
Show resolved
Hide resolved
akucharska
approved these changes
Jul 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
note:
Select
component doesn't currently pass theref
properly to the input (SAP/fundamental-react#1336), it just passes it to the wrapper. I still used refs in most places as hopefully this will be fixed, and it would be enough to just remove few lines of workarounds.Related issue(s)