Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify dropdowns #273

Merged
merged 26 commits into from
Jul 15, 2021
Merged

Conversation

dariadomagala-sap
Copy link
Contributor

@dariadomagala-sap dariadomagala-sap commented Jul 7, 2021

Description

Changes proposed in this pull request:

  • Bump fundamental to 0.14-rc100000000
  • Use one shared component for all dropdowns
  • Fix the issue with deleting Bindings from Instance Details
  • Fix the issue of always disabled 'Add Service Binding' buttons (it expected bindable Instances to exist for the button to be enabled, but the call for the instances was triggered after clicking the button..)
  • Fix the issue of not being able to choose a different auth method for the Git Repository

note: Select component doesn't currently pass the ref properly to the input (SAP/fundamental-react#1336), it just passes it to the wrapper. I still used refs in most places as hopefully this will be fixed, and it would be enough to just remove few lines of workarounds.

Related issue(s)

@kyma-bot kyma-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 7, 2021
@kyma-bot kyma-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 9, 2021
@kyma-bot kyma-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 13, 2021
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jul 15, 2021
@kyma-bot kyma-bot merged commit 8a04d2f into kyma-project:main Jul 15, 2021
@Sawthis Sawthis linked an issue Jul 15, 2021 that may be closed by this pull request
@dariadomagala-sap dariadomagala-sap deleted the unify-dropdowns branch July 15, 2021 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Looks good to me! size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unify the look and feel for drop downs
3 participants