Support for wasm32-unknown-unknown target (WebGL) #149

caiiiycuk · 2021-11-18T11:25:24Z

I tried to update wgpu to 0.11.0 (in order to support WebGL in future). I fixed some initialization code and now it compiles but render black screen, can you please point me what I did wrong.

Platform: linux
Renderer: vulkan

caiiiycuk · 2021-11-18T11:57:58Z

Also _pad: vec2 in shader seems unused, I renamed it to apad because shader won’t compile

README.md

kvark · 2021-11-18T22:32:16Z

Please rebase!

caiiiycuk · 2021-11-19T10:44:39Z

Everything looks working, but seems render is not fit for webgl, have this issue:

road.js:1416 panicked at 'wgpu error: Validation Error

Caused by:
    In Device::create_bind_group_layout
      note: label = `Shape`
    binding 0 entry is invalid
    Downlevel flags VERTEX_STORAGE are required but not supported on the device.
This is not an invalid use of WebGPU: the underlying API or device does not support enough features to be a fully compliant implementation. A subset of the features can still be used. If you are running this program on native and not in a browser and wish to work around this issue, call Adapter::downlevel_properties or Device::downlevel_properties to get a listing of the features the current platform supports.

kvark · 2021-11-19T15:47:25Z

Please file this separately, I'll address it shortly.

caiiiycuk · 2021-11-20T04:28:26Z

#150

bin/road/main.rs

bin/boilerplate.rs

caiiiycuk · 2021-12-09T17:42:11Z

Please comment what to fix, I will update README.md soon

kvark

Amazing work!

kvark · 2021-12-09T18:09:33Z

.github/workflows/check.yml

@@ -1,9 +1,9 @@
 name: Check
 on:
  push:
-    branches: [master]
+    branches: [master, vange-rs-web]


since we are already in vange-rs repo, perhaps the branch could just be called web?

kvark · 2021-12-09T18:10:15Z

.github/workflows/check.yml

@@ -14,7 +14,9 @@ jobs:
    runs-on: ${{ matrix.os }}
    steps:
    - uses: actions/checkout@v2
+    - run: rustup target add wasm32-unknown-unknown


let's add a note to tell what we are doing to whoever is reading the log

kvark · 2021-12-09T18:11:26Z

README.md

+
+**Resources**
+
+To build game **you must** put resources of original game in `res_linux/data` folder.


why is this res_linux specifically and not some web/resources for example?

kvark · 2021-12-09T18:15:54Z

bin/web.rs

+use wasm_bindgen::prelude::*;
+use wasm_bindgen::JsCast;
+
+extern crate console_error_panic_hook;


you don't need to declare extern crates like this any more in Rust

kvark · 2021-12-09T18:21:35Z

bin/web.rs

+        create_file!("data/wrlds.dat", get_bundled_file!());
+
+        // the chain
+        create_file!("data/thechain/threall/world.ini", get_bundled_file!());


We should probably do it in build.rs, for multiple reasons. First, we could drive this by data or environment instead of a cargo feature, which means there is less enabling/disabling of code paths going on.
And secondly, most importantly, we could just walk the directory tree and pick up all the files we need, instead of enumerating every single filename/path.

kvark · 2021-12-09T18:22:30Z

gen.py

+        print("\tcreate_file(\"" + path + "\", include_bytes!(\"../" + path + "\"));");
+
+print("\n\t// vangers resouces")
+for root, subdirs, files in os.walk("res_linux"):


ok, yeah, a build.rs script would be much better than a python script :)

kvark · 2021-12-09T18:36:47Z

bin/web.rs

+    let window = web_sys::window().expect("should have a window in this context");
+
+    {
+        let mappings: HashMap<String, Key> = [


the key should be &'static str instead of String

kvark · 2021-12-09T18:39:07Z

web/index.html

+    </script>
+
+    <script>
+        const filesToFetch = [


would be nice to have this queried instead of hard-coded, but we can do it as a follow-up

kvark · 2021-12-09T18:50:04Z

web/index.html

+        const generateConfig = (level) => `
+(
+	data_path: "data",
+	game: (


would it be feasible to read the config from the file? e.g. in build script.

caiiiycuk force-pushed the vange-rs-web branch from ee8482c to b14582b Compare November 18, 2021 11:27

Fenex reviewed Nov 18, 2021

View reviewed changes

README.md Outdated Show resolved Hide resolved

kvark force-pushed the master branch from 776d730 to 10e8e6b Compare November 18, 2021 22:31

caiiiycuk force-pushed the vange-rs-web branch 2 times, most recently from c36b8c4 to d646cca Compare November 19, 2021 10:41

caiiiycuk force-pushed the vange-rs-web branch 3 times, most recently from 9692635 to ff6c3ed Compare November 22, 2021 07:06

caiiiycuk force-pushed the vange-rs-web branch 2 times, most recently from 826999a to 0416e4c Compare November 29, 2021 04:36

caiiiycuk force-pushed the vange-rs-web branch from 0416e4c to f4b541c Compare December 6, 2021 04:55

kvark reviewed Dec 6, 2021

View reviewed changes

bin/road/main.rs Outdated Show resolved Hide resolved

caiiiycuk force-pushed the vange-rs-web branch 4 times, most recently from 2b9a96b to 3a79885 Compare December 9, 2021 08:53

Fenex reviewed Dec 9, 2021

View reviewed changes

bin/boilerplate.rs Show resolved Hide resolved

caiiiycuk force-pushed the vange-rs-web branch 8 times, most recently from c340ea2 to 853515e Compare December 9, 2021 17:26

caiiiycuk force-pushed the vange-rs-web branch 2 times, most recently from 6bc3562 to de2b7c8 Compare December 9, 2021 17:33

caiiiycuk marked this pull request as ready for review December 9, 2021 17:41

caiiiycuk changed the title ~~[DRAFT] Support for wasm32-unknown-unknown target~~ Support for wasm32-unknown-unknown target (WebGL) Dec 9, 2021

caiiiycuk requested a review from kvark December 9, 2021 17:42

kvark reviewed Dec 9, 2021

View reviewed changes

wasm32-unknown-unknown

9da4648

caiiiycuk force-pushed the vange-rs-web branch from de2b7c8 to 9da4648 Compare December 10, 2021 04:24

Fenex added 2 commits December 10, 2021 22:20

fix: double import bin/web module

63e4255

fix(web): use iterior-mutability instead of unsafe

4ac491e

kvark force-pushed the master branch from 040f148 to 74d8b93 Compare November 8, 2022 08:02

kvark force-pushed the master branch from 523fdfc to 8e25e16 Compare December 15, 2023 05:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support for wasm32-unknown-unknown target (WebGL) #149

Support for wasm32-unknown-unknown target (WebGL) #149

caiiiycuk commented Nov 18, 2021

caiiiycuk commented Nov 18, 2021

kvark commented Nov 18, 2021

caiiiycuk commented Nov 19, 2021

kvark commented Nov 19, 2021

caiiiycuk commented Nov 20, 2021

caiiiycuk commented Dec 9, 2021

kvark left a comment

kvark Dec 9, 2021

kvark Dec 9, 2021

kvark Dec 9, 2021

kvark Dec 9, 2021

kvark Dec 9, 2021

kvark Dec 9, 2021

kvark Dec 9, 2021

kvark Dec 9, 2021

kvark Dec 9, 2021


		Resources

		To build game you must put resources of original game in `res_linux/data` folder.

Support for wasm32-unknown-unknown target (WebGL) #149

Are you sure you want to change the base?

Support for wasm32-unknown-unknown target (WebGL) #149

Conversation

caiiiycuk commented Nov 18, 2021

caiiiycuk commented Nov 18, 2021

kvark commented Nov 18, 2021

caiiiycuk commented Nov 19, 2021

kvark commented Nov 19, 2021

caiiiycuk commented Nov 20, 2021

caiiiycuk commented Dec 9, 2021

kvark left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment