Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "ci(checklinks): exclude external website from checklinks" #2118

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Revert "ci(checklinks): exclude external website from checklinks" #2118

wants to merge 1 commit into from

Conversation

slonka
Copy link
Contributor

@slonka slonka commented Dec 10, 2024

Reverts #2116

As explained in the review, this is not the way. If we go down this road we might as well disable all external links checking.

@slonka slonka requested a review from a team as a code owner December 10, 2024 09:50
@slonka slonka requested review from bartsmykla and schogges and removed request for a team December 10, 2024 09:50
@netlify Netlify
Copy link

netlify bot commented Dec 10, 2024 •
edited
Loading

✅ Deploy Preview for kuma ready!

Name Link
🔨 Latest commit 4af83ae
🔍 Latest deploy log https://app.netlify.com/sites/kuma/deploys/67580ef400e896000822952c
😎 Deploy Preview https://deploy-preview-2118--kuma.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 93 (🟢 up 9 from production)
Accessibility: 90 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@slonka slonka added the blocked This is blocked by another issue or something external label Dec 10, 2024
@slonka slonka mentioned this pull request Dec 10, 2024
Open
@slonka
Copy link
Contributor Author

slonka commented Dec 10, 2024

Blocked on #2119

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartsmykla bartsmykla Awaiting requested review from bartsmykla bartsmykla is a code owner automatically assigned from kumahq/kuma-website-maintainers

@schogges schogges Awaiting requested review from schogges schogges is a code owner automatically assigned from kumahq/kuma-website-maintainers

@jijiechen jijiechen Awaiting requested review from jijiechen

@Icarus9913 Icarus9913 Awaiting requested review from Icarus9913

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
blocked This is blocked by another issue or something external
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@slonka