feature: adds v-style directive #3458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for kuma-gui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
johncowen
force-pushed
the
feat/v-style
branch
3 times, most recently
from
34d7411 to
75cccde
Compare
Signed-off-by: John Cowen <[email protected]>
Signed-off-by: John Cowen <[email protected]>
johncowen
force-pushed
the
feat/v-style
branch
from
75cccde to
9dd816f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
v-styledirective to allow us to set occasional inline styles within a strict CSP environment.Additionally makes it easy to add simple CSS transitions that often require waiting a tick before applying a rule.
Note: There are a couple of unrelated changes here that I bumped into whilst working on this. Happy to split those off if necessary.
P.S. I need to add some sort of👈 this is doneSet.differencepolyfill here, its a bit new at the moment.**P.P.S. CypressesChromeElectron (ooooh it uses Electron 🤔 ) doesn't support Set.difference either so it also failed our tests 🎉 **