chore(deps): upgrade reflect-metadata #3384
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: John Cowen <[email protected]>
johncowen
changed the title
✅ Deploy Preview for kuma-gui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FYI: You will only see a warning for the issue here if you run
make installwith completely cleannode_modulesI chose to put the override in the root package.json, I also had to run
npm dedupeseveral times to get it to "stick" so unfortunately quite a lot of churn in the package-lock.json.I just looked at it myself, and there are lots of downgrades of some transitive dependencies here (as well as upgrades). I would assume these still satisfy the semver ranges for everything and are a consequence of the dedupe's.
Ideally I'd like less churn here though, so if there are any suggestions/ideas for trying to get a smaller changeset I'd be very grateful. Otherwise I think this is probably still good as it seems like the changed deps are mostly (at least) dev/tooling deps.