Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow custom URLs and auth connector to support our Skaffold setup #6003

Merged
merged 2 commits into from
Nov 5, 2024
Merged

fix: allow custom URLs and auth connector to support our Skaffold setup #6003

merged 2 commits into from
Nov 5, 2024

Conversation

rangoo94
Copy link
Member

@rangoo94 rangoo94 commented Nov 5, 2024 •
edited
Loading

Pull request description

  • Allow custom auth connector (with --custom-auth) and all the URLs
  • Fix overriding namespace in testkube dashboard command

Checklist (choose whats happened)

  • breaking change! (describe)
  • tested locally
  • tested on cluster
  • added new dependencies
  • updated the docs
  • added a test

Fixes

@rangoo94 rangoo94 requested review from a team as code owners November 5, 2024 08:06
@rangoo94 rangoo94 merged commit 130be44 into main Nov 5, 2024
24 checks passed
@rangoo94 rangoo94 deleted the dawid/fix/demo-and-skaffold-setup branch November 5, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WitoDelnat WitoDelnat WitoDelnat approved these changes

@vsukhin vsukhin vsukhin approved these changes

@exu exu exu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rangoo94 @exu @vsukhin @WitoDelnat