Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump Go to 1.23 #5985

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Conversation

kennethredler
Copy link
Contributor

@kennethredler kennethredler commented Oct 29, 2024

Pull request description

Updates go to 1.23.2.

Relates to #5905

Checklist (choose whats happened)

  • breaking change! (describe)
  • tested locally
  • tested on cluster
  • added new dependencies
  • updated the docs
  • added a test

Breaking changes

Changes

Fixes

@kennethredler kennethredler requested a review from a team as a code owner October 29, 2024 19:56
@kennethredler
Copy link
Contributor Author

🎁 Welcome @vsukhin review, please. 🙏🏻

@codecov-commenter
Copy link

codecov-commenter commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 22.02%. Comparing base (69dcd7f) to head (90b5955).
Report is 2246 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5985      +/-   ##
==========================================
- Coverage   25.80%   22.02%   -3.79%     
==========================================
  Files         198      577     +379     
  Lines       15240    57110   +41870     
==========================================
+ Hits         3933    12578    +8645     
- Misses      10917    43332   +32415     
- Partials      390     1200     +810     
Flag Coverage Δ
integrationtests 3.76% <ø> (-4.13%) ⬇️
unittests 19.56% <ø> (-0.91%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kennethredler
Copy link
Contributor Author

kennethredler commented Oct 29, 2024

Thank you for the review @vsukhin 😃👍🏻

Is there anything further I should do to have this merged?

@vsukhin
Copy link
Collaborator

vsukhin commented Oct 30, 2024

no, I will merge it today

@vsukhin vsukhin merged commit 1d8dd99 into kubeshop:main Oct 30, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants