feat: improve agent startup time #5976
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WitoDelnat
commented
Oct 28, 2024
| @@ -126,16 +124,32 @@ func main() { | |||
|
|
|||
| inspector := commons.CreateImageInspector(cfg, configMapClient, secretClient) | |||
|
|
|||
| // Connect to NATS | |||
There was a problem hiding this comment.
Moving NATS first staggers the gRPC connection a bit when we start agent and control plane together. gRPC backoff is quite steep, but I want to avoid tweaking it until absolutely needed as these defaults are there for a reason.
WitoDelnat
commented
Oct 28, 2024
| defer grpcConn.Close() | ||
|
|
||
| // First request will 'wait for ready' with a timeout of agent.InitialTimeout. | ||
| proContext, err := commons.ReadProContext(ctx, cfg, grpcClient) |
There was a problem hiding this comment.
Moved this up a bit, as it groups nicely with the grpcConnection part, this is where we actually wait for the connection to move from idle -> transient error -> ready.
WitoDelnat
commented
Oct 28, 2024
| @@ -31,7 +31,8 @@ import ( | |||
| ) | |||
|
|
|||
| const ( | |||
| timeout = 10 * time.Second | |||
| InitialTimeout = 30 * time.Second | |||
There was a problem hiding this comment.
With gRPC backoff this would amount to: 1 + 1.6 + 2.5 + 4 +6.5 + 10.5 -> CRASH after 30s, last attempt at 26.1s. Kubernetes will then restart the pod and it will try again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request description
Checklist (choose whats happened)
Breaking changes
Changes
Fixes