Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for webhook options in helm template #1196

Closed
wants to merge 0 commits into from
Closed

Add support for webhook options in helm template #1196

wants to merge 0 commits into from

Conversation

messedupryan
Copy link

Issue: #1195

Description

Changes proposed in this pull request:

  • Add support for setting webhook options via helm chart

Testing

values.yaml

communications:
  'default-group':
    webhook:
      enabled: true
      url: http://echoserver-echo-server
      bindings:
        sources:
          - k8s-all-events

install helm chart

helm install botkube helm/botkube/ -f values.yaml

test result

k get cm botkube-runtime-config -o yaml -n botkube | grep -A6 webhook  
        webhook:
          enabled: true
          url: http://echoserver-echo-server
          bindings:
            sources:
              - k8s-all-events

Related issue(s)

Resolves #1195

@messedupryan messedupryan requested review from PrasadG193 and a team as code owners August 16, 2023 23:58
@pkosiec pkosiec self-assigned this Aug 17, 2023
@pkosiec pkosiec added the hold label Aug 17, 2023
@pkosiec
Copy link
Member

pkosiec commented Aug 17, 2023

Hey @messedupryan, thank you for your contribution. Please see my reply here: #1195 (comment). I'd like to understand first what issue(s) you're trying to solve. Cheers!

@pkosiec pkosiec added the needs-more-info Further information is needed label Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hold needs-more-info Further information is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

helm chart options for specifying webhook configuration do not apply settings to the configMap
2 participants