Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix migration test after 1.2.0 release #1158

Merged
merged 1 commit into from
Jul 20, 2023

Conversation

pkosiec
Copy link
Member

@pkosiec pkosiec commented Jul 20, 2023

Description

Changes proposed in this pull request:

  • Fix migration test after 1.2.0 release

See failed run:
https://github.com/kubeshop/botkube/actions/runs/5600763602/jobs/10244234617

  migration_test.go:143: 
        	Error Trace:	/home/runner/work/botkube/botkube/test/e2e/migration_test.go:252
        	            				/home/runner/work/botkube/botkube/test/e2e/migration_test.go:143
        	Error:      	"[%!s(*graphql.Alias=&{d620f1a5-3db1-4c84-bcfe-e9ea943e3137 k Kubectl alias kubectl [0xc000a01dc0]}) %!s(*graphql.Alias=&{fbb18af9-7cfc-442b-8ad1-b35c187b5874 kc Kubectl alias kubectl [0xc000a01e00]}) %!s(*graphql.Alias=&{5a9f73d4-5dfd-4d2d-9508-3a7dea1aac66 x Exec alias exec [0xc000a01e20]}) %!s(*graphql.Alias=&{d70238b0-e493-48be-a4b5-891085dc9fba chatgpt Doctor alias doctor [0xc000a01e40]})]" should have 2 item(s), but has 4
        	Test:       	TestBotkubeMigration/Check_if_the_instance_is_created_on_Botkube_Cloud_side
    migration_test.go:143: 
        	Error Trace:	/home/runner/work/botkube/botkube/test/e2e/migration_test.go:260
        	            				/home/runner/work/botkube/botkube/test/e2e/migration_test.go:143
        	Error:      	elements differ
        	            	
        	            	extra elements in list B:
        	            	([]interface {}) (len=2) {
        	            	 (*graphql.Alias)({
        	            	  ID: (string) "",
        	            	  Name: (string) (len=1) "x",
        	            	  DisplayName: (string) (len=10) "Exec alias",
        	            	  Command: (string) (len=4) "exec",
        	            	  Deployments: ([]*graphql.DeploymentInfo) <nil>
        	            	 }),
        	            	 (*graphql.Alias)({
        	            	  ID: (string) "",
        	            	  Name: (string) (len=7) "chatgpt",
        	            	  DisplayName: (string) (len=12) "Doctor alias",
        	            	  Command: (string) (len=6) "doctor",
        	            	  Deployments: ([]*graphql.DeploymentInfo) <nil>
        	            	 })
        	            	}
        	            	

@pkosiec pkosiec added the bug Something isn't working label Jul 20, 2023
@pkosiec pkosiec changed the title Fix migration test Fix migration test after 1.2.0 release Jul 20, 2023
@pkosiec pkosiec marked this pull request as ready for review July 20, 2023 07:20
@pkosiec pkosiec requested review from a team and PrasadG193 as code owners July 20, 2023 07:20
Copy link

@josefkarasek josefkarasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@pkosiec pkosiec merged commit f8ac3c1 into kubeshop:main Jul 20, 2023
13 checks passed
@pkosiec pkosiec deleted the fix-migration-test branch July 20, 2023 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants