Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exit with Fatal if we cannot write to closed ws #18

Closed
wants to merge 1 commit into from

Conversation

matthyx
Copy link
Collaborator

@matthyx matthyx commented Nov 29, 2023

{"level":"error","ts":"2023-11-29T12:45:55Z","msg":"cannot send message","error":"use of closed network connection"}
{"level":"error","ts":"2023-11-29T12:46:45Z","msg":"cannot send message","error":"use of closed network connection"}
{"level":"error","ts":"2023-11-29T12:47:35Z","msg":"cannot send message","error":"use of closed network connection"}
{"level":"error","ts":"2023-11-29T12:48:25Z","msg":"cannot send message","error":"use of closed network connection"}
{"level":"error","ts":"2023-11-29T12:49:15Z","msg":"cannot send message","error":"use of closed network connection"}
{"level":"error","ts":"2023-11-29T12:50:05Z","msg":"cannot send message","error":"use of closed network connection"}
{"level":"error","ts":"2023-11-29T12:50:55Z","msg":"cannot send message","error":"use of closed network connection"}
{"level":"error","ts":"2023-11-29T12:51:45Z","msg":"cannot send message","error":"use of closed network connection"}
{"level":"error","ts":"2023-11-29T12:52:35Z","msg":"cannot send message","error":"use of closed network connection"}

Copy link

Summary:

  • License scan: failure
  • Credentials scan: success
  • Vulnerabilities scan: success
  • Unit test: success
  • Go linting: success

@matthyx matthyx marked this pull request as draft November 29, 2023 14:15
@matthyx
Copy link
Collaborator Author

matthyx commented Nov 29, 2023

this is a workaround until I write a full connection handler like https://github.com/minio/minio/blob/0ee722f8c3b3d8b566c6d4b648d71b65bbf3a54b/internal/grid/connection.go

@matthyx matthyx marked this pull request as ready for review December 14, 2023 09:09
Copy link

Summary:

  • License scan: failure
  • Credentials scan: success
  • Vulnerabilities scan: success
  • Unit test: success
  • Go linting: success

@dwertent
Copy link

@matthyx so should we merge this until you write the workaround?

@matthyx
Copy link
Collaborator Author

matthyx commented Dec 20, 2023

no, don't touch it - we need to behave differently between client and server

@matthyx matthyx closed this Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants