Skip to content

Commit

Permalink
lint: Add linters to makefile / github CI
Browse files Browse the repository at this point in the history
Not yet ready to make gating, but we can watch the progress.
  • Loading branch information
justinsb authored and thockin committed Jul 29, 2023
1 parent d86e70f commit 8656ab6
Show file tree
Hide file tree
Showing 2 changed files with 35 additions and 0 deletions.
27 changes: 27 additions & 0 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -46,3 +46,30 @@ jobs:
working-directory: git-sync
run: |
make test
lint:
runs-on: ubuntu-latest
steps:
- name: Set up go
uses: actions/setup-go@v4
with:
go-version: '1.20.6'

- uses: actions/checkout@v3
with:
path: git-sync

# We run the github action, even though this is duplicated in `make lint` below.
# This is because the action gives easier-to-read output than the linter.
# There is a risk of drift between the two, but this is only linting,
# not runtime correctness!
- name: golangci-lint
uses: golangci/golangci-lint-action@v3
with:
working-directory: git-sync
version: v1.53.3

- name: make lint
working-directory: git-sync
run: |
make lint
8 changes: 8 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -276,3 +276,11 @@ container-clean:

bin-clean:
rm -rf .go bin

lint-staticcheck:
go run honnef.co/go/tools/cmd/[email protected]

lint-golangci-lint:
go run github.com/golangci/golangci-lint/cmd/[email protected] run

lint: lint-staticcheck lint-golangci-lint

0 comments on commit 8656ab6

Please sign in to comment.