Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename ImportClusterResourceService to OneshotClusterResourceImporter #365

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

saza-ku
Copy link
Contributor

@saza-ku saza-ku commented Aug 21, 2024

What type of PR is this?

/area simulator
/kind cleanup

What this PR does / why we need it:

If we add the syncing service (#327), it has two features to import resources of a real cluster, one-shot importing and continuous syncing.
So the current naming of ImportClusterResouceService would be confusing.

This PR renames ImportClusterResourceService to OneshotClusterResourceImporter. This will avoid the confusion.

Which issue(s) this PR fixes:

Part of #327

Special notes for your reviewer:

We should also rename mock_clusterresourceimporter, but this is generated by gomock so we need to replace golang/mock with uber-go/mock (#363). This PR once leaves it.

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added area/simulator Issues or PRs related to the simulator. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. labels Aug 21, 2024
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 21, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @saza-ku. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 21, 2024
@saza-ku saza-ku changed the title rename ImportClusterResourceService to OneshotClusterResourceImporter Rename ImportClusterResourceService to OneshotClusterResourceImporter Aug 21, 2024
Copy link
Member

@utam0k utam0k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm from my eyes

The code itself looks good. But I'd like to know @sanposhiho's opinion.

@sanposhiho
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 21, 2024
Copy link
Member

@sanposhiho sanposhiho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 21, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ordovicia, sanposhiho, saza-ku

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 21, 2024
@k8s-ci-robot k8s-ci-robot merged commit f3efb67 into kubernetes-sigs:master Aug 21, 2024
5 checks passed
YamasouA pushed a commit to YamasouA/kube-scheduler-simulator that referenced this pull request Aug 30, 2024
YamasouA pushed a commit to YamasouA/kube-scheduler-simulator that referenced this pull request Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/simulator Issues or PRs related to the simulator. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants