Skip to content

Commit

Permalink
Fix a few warnings about old Dockerfile and Docker Compose syntax (#392)
Browse files Browse the repository at this point in the history
  • Loading branch information
jgiannuzzi authored Nov 11, 2024
1 parent d3cf03d commit 70484f1
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 7 deletions.
1 change: 0 additions & 1 deletion compose.local.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
# Note for maintainers: When making a change in this file,
# you're likely to make the same change in simulator/docs/sample/plugin-extender/docker-compose.yaml.
version: "3.7"
services:
# This container copies the data,
# so any changes made to the configuration files within the Pod will not affect the original files.
Expand Down
1 change: 0 additions & 1 deletion simulator/docs/sample/plugin-extender/docker-compose.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
version: "3.7"
services:
extender:
image: test/test:test # TODO(user): replace it with your extender's image
Expand Down
10 changes: 5 additions & 5 deletions web/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,13 @@ RUN yarn build && yarn install --production --ignore-scripts --prefer-offline
FROM node:16-alpine AS runner
WORKDIR /app

ENV NODE_ENV production
ENV NUXT_TELEMETRY_DISABLED 1
ENV NODE_ENV=production
ENV NUXT_TELEMETRY_DISABLED=1
# Currnently, HOST_ENV is used to decide whether to import the TEMPLATE files of the k8s resources.
# ./components/lib/templates/*.yaml
ENV HOST_ENV production
ENV BASE_URL http://localhost:1212
ENV KUBE_API_SERVER_URL http://localhost:3131
ENV HOST_ENV=production
ENV BASE_URL=http://localhost:1212
ENV KUBE_API_SERVER_URL=http://localhost:3131

RUN addgroup -g 1001 -S nodejs
RUN adduser -S nuxtjs -u 1001
Expand Down

0 comments on commit 70484f1

Please sign in to comment.