Added support to setup the containerPort property of the container we…

…bhook Signed-off-by: Javier Vela <[email protected]>
kubernetes-sigs · Jan 8, 2025 · fd56d69 · fd56d69
1 parent f8057a7
commit fd56d69
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 1 deletion.
diff --git a/charts/external-dns/CHANGELOG.md b/charts/external-dns/CHANGELOG.md
@@ -22,6 +22,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 - Ability to configure `imagePullSecrets` via helm `global` value ([#4667](https://github.com/kubernetes-sigs/external-dns/pull/4667)) _@jkroepke_
 - Added options to configure `labelFilter` and `managedRecordTypes` via dedicated helm values ([#4849](https://github.com/kubernetes-sigs/external-dns/pull/4849)) _@abaguas_
+- Added support to setup the `containerPort` property of the container `webhook` ([4934](https://github.com/kubernetes-sigs/external-dns/issues/4934)) _@fjvela_
 
 ### Fixed
 

diff --git a/charts/external-dns/README.md b/charts/external-dns/README.md
@@ -127,6 +127,7 @@ If `namespaced` is set to `true`, please ensure that `sources` my only contains
 | priorityClassName | string | `nil` | Priority class name for the `Pod`. |
 | provider.name | string | `"aws"` | _ExternalDNS_ provider name; for the available providers and how to configure them see [README](https://github.com/kubernetes-sigs/external-dns/blob/master/charts/external-dns/README.md#providers). |
 | provider.webhook.args | list | `[]` | Extra arguments to provide for the `webhook` container. |
+| provider.webhook.containerPort | int | `8080` | Container port for the `webhook` container. |
 | provider.webhook.env | list | `[]` | [Environment variables](https://kubernetes.io/docs/tasks/inject-data-application/define-environment-variable-container/) for the `webhook` container. |
 | provider.webhook.extraVolumeMounts | list | `[]` | Extra [volume mounts](https://kubernetes.io/docs/concepts/storage/volumes/) for the `webhook` container. |
 | provider.webhook.image.pullPolicy | string | `"IfNotPresent"` | Image pull policy for the `webhook` container. |

diff --git a/charts/external-dns/templates/deployment.yaml b/charts/external-dns/templates/deployment.yaml
@@ -166,7 +166,7 @@ spec:
           ports:
             - name: http-webhook
               protocol: TCP
-              containerPort: 8080
+              containerPort: {{ .containerPort }}
           livenessProbe:
             {{- toYaml .livenessProbe | nindent 12 }}
           readinessProbe:

diff --git a/charts/external-dns/values.yaml b/charts/external-dns/values.yaml
@@ -239,6 +239,8 @@ provider:
   # -- _ExternalDNS_ provider name; for the available providers and how to configure them see [README](https://github.com/kubernetes-sigs/external-dns/blob/master/charts/external-dns/README.md#providers).
   name: aws
   webhook:
+    containerPort: 8080
+
     image:
       # -- (string) Image repository for the `webhook` container.
       repository: