Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Conformance: Fix warnings #2357

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

🌱 Conformance: Fix warnings #2357

wants to merge 1 commit into from

Conversation

lentzi90
Copy link
Contributor

@lentzi90 lentzi90 commented Jan 10, 2025 •
edited
Loading

What this PR does / why we need it:

  • Fix case mismatch in Dockerfile
  • Fix ginkgo deprecated flags
  • Fix controller runtime SetLogger never called

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squashed commits
  • if necessary:
    • includes documentation
    • adds unit tests

/hold

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 10, 2025
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 10, 2025
@lentzi90
Copy link
Contributor Author

/test ?

@k8s-ci-robot
Copy link
Contributor

@lentzi90: The following commands are available to trigger required jobs:

/test pull-cluster-api-provider-openstack-build

/test pull-cluster-api-provider-openstack-e2e-test

/test pull-cluster-api-provider-openstack-test

The following commands are available to trigger optional jobs:

/test pull-cluster-api-provider-openstack-conformance-test

/test pull-cluster-api-provider-openstack-e2e-full-test

Use /test all to run the following jobs that were automatically triggered:

pull-cluster-api-provider-openstack-build

pull-cluster-api-provider-openstack-e2e-test

pull-cluster-api-provider-openstack-test

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@netlify Netlify
Copy link

netlify bot commented Jan 10, 2025 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
🔨 Latest commit d3b6e98
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/67814d7a5b85db000737b791
😎 Deploy Preview https://deploy-preview-2357--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@lentzi90
Copy link
Contributor Author

/test pull-cluster-api-provider-openstack-conformance-test

@lentzi90 lentzi90 mentioned this pull request Jan 10, 2025
Merged
@lentzi90 lentzi90 force-pushed the lentzi90/conformance-suite-fix branch from d1f3929 to 13b43d3 Compare January 10, 2025 13:27
@lentzi90
Copy link
Contributor Author

/test pull-cluster-api-provider-openstack-conformance-test

@lentzi90 lentzi90 changed the title Try not using CI-artifacts for conformance tests 🌱 Conformance: Fix warnings Jan 10, 2025
@lentzi90 lentzi90 marked this pull request as ready for review January 10, 2025 13:51
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 10, 2025
@k8s-ci-robot k8s-ci-robot requested a review from jichenjc January 10, 2025 13:51
@lentzi90
Copy link
Contributor Author

/test pull-cluster-api-provider-openstack-conformance-test

@lentzi90
Conformance: Fix warnings
d3b6e98 
- Fix case mismatch in Dockerfile
- Fix ginkgo deprecated flags
- Fix controller runtime SetLogger never called

Signed-off-by: Lennart Jern <[email protected]>
@lentzi90 lentzi90 force-pushed the lentzi90/conformance-suite-fix branch from 13b43d3 to d3b6e98 Compare January 10, 2025 16:40
@lentzi90
Copy link
Contributor Author

/test pull-cluster-api-provider-openstack-conformance-test

@EmilienM
Copy link
Contributor

/lgtm
/approve
thanks for doing that

I'll let you hold cancel when you think it's ready.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 10, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: EmilienM

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EmilienM EmilienM Awaiting requested review from EmilienM

@mdbooth mdbooth Awaiting requested review from mdbooth

@jichenjc jichenjc Awaiting requested review from jichenjc

Assignees

@EmilienM EmilienM

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
CAPO Roadmap
Status: Inbox
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lentzi90 @k8s-ci-robot @EmilienM