-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Remove ORC from CAPO #2346
🌱 Remove ORC from CAPO #2346
Conversation
✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
TODO: deploy ORC in e2e |
10febc8
to
31afcc9
Compare
/cc mandre pierreprinetti |
967eb78
to
a5a284b
Compare
/test pull-cluster-api-provider-openstack-e2e-full-test |
10542dd
to
0bd0b6e
Compare
/test pull-cluster-api-provider-openstack-e2e-full-test |
/test pull-cluster-api-provider-openstack-e2e-full-test |
/test pull-cluster-api-provider-openstack-e2e-full-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noice. Some nits/thoughts inline, but nothing I'd insist on.
test/e2e/data/shared/openstack-resource-controller/metadata.yaml
Outdated
Show resolved
Hide resolved
/test pull-cluster-api-provider-openstack-e2e-full-test |
/test pull-cluster-api-provider-openstack-e2e-test pull-cluster-api-provider-openstack-e2e-full-test |
/test pull-cluster-api-provider-openstack-e2e-full-test |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice to deploy it as a RuntimeExtension!
I don't quite get why you included the go version bump here, but we sure need it at some point
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lentzi90 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This pull request removes the in-tree ORC (OpenStack Resource Controller) integration from the project to use the one that is out of tree.
Removal of ORC Integration:
Makefile
: Removed all references and targets related to ORC, includingtest-orc
,lint
,generate-orc
, andverify-orc
. [1] [2] [3] [4] [5] [6] [7]config/default/kustomization.yaml
: Removed ORC configuration paths.config/rbac/role.yaml
: Removed ORC-related API groups and resources.main.go
: Removed ORC controllers and related imports. [1] [2]orc/
).Go Version Update:
Dockerfile
: Updated the Go version from1.22.0
to1.23.0
.go.mod
: Updated the Go version and dependencies, and removed the local replace directive for ORC. [1] [2] [3] [4]hack/tools/go.mod
: Updated the Go version and dependencies, and removed the local replace directive for ORC. [1] [2] [3] [4]Deploy ORC for e2e tests
Using CAPI machinery, ORC will be deployed as a
RuntimeExtensionProvider
.Document how ORC can be deployed
It was decided that ORC should be manually deployed by the user and CAPO wouldn't handle it. So there is a documentation section explaining how to proceed.