Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Remove ORC from CAPO #2346

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Conversation

EmilienM
Copy link
Contributor

@EmilienM EmilienM commented Dec 30, 2024

This pull request removes the in-tree ORC (OpenStack Resource Controller) integration from the project to use the one that is out of tree.

Removal of ORC Integration:

Go Version Update:

  • Dockerfile: Updated the Go version from 1.22.0 to 1.23.0.
  • go.mod: Updated the Go version and dependencies, and removed the local replace directive for ORC. [1] [2] [3] [4]
  • hack/tools/go.mod: Updated the Go version and dependencies, and removed the local replace directive for ORC. [1] [2] [3] [4]

Deploy ORC for e2e tests

Using CAPI machinery, ORC will be deployed as a RuntimeExtensionProvider.

Document how ORC can be deployed

It was decided that ORC should be manually deployed by the user and CAPO wouldn't handle it. So there is a documentation section explaining how to proceed.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 30, 2024
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Dec 30, 2024
Copy link

netlify bot commented Dec 30, 2024

Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
🔨 Latest commit 8f69620
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/6785163884c281000809d3a7
😎 Deploy Preview https://deploy-preview-2346--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@EmilienM
Copy link
Contributor Author

TODO: deploy ORC in e2e

@EmilienM EmilienM force-pushed the orc branch 2 times, most recently from 10febc8 to 31afcc9 Compare December 30, 2024 13:54
@EmilienM
Copy link
Contributor Author

/cc mandre pierreprinetti

@EmilienM
Copy link
Contributor Author

EmilienM commented Jan 9, 2025

/test pull-cluster-api-provider-openstack-e2e-full-test

@EmilienM EmilienM force-pushed the orc branch 6 times, most recently from 10542dd to 0bd0b6e Compare January 10, 2025 13:46
@EmilienM
Copy link
Contributor Author

/test pull-cluster-api-provider-openstack-e2e-full-test

@EmilienM
Copy link
Contributor Author

/test pull-cluster-api-provider-openstack-e2e-full-test

@EmilienM
Copy link
Contributor Author

/test pull-cluster-api-provider-openstack-e2e-full-test

Copy link
Contributor

@mdbooth mdbooth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice. Some nits/thoughts inline, but nothing I'd insist on.

go.mod Show resolved Hide resolved
@EmilienM
Copy link
Contributor Author

/test pull-cluster-api-provider-openstack-e2e-full-test

@EmilienM
Copy link
Contributor Author

/test pull-cluster-api-provider-openstack-e2e-test pull-cluster-api-provider-openstack-e2e-full-test

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 13, 2025
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 13, 2025
@EmilienM
Copy link
Contributor Author

/test pull-cluster-api-provider-openstack-e2e-full-test

@mdbooth
Copy link
Contributor

mdbooth commented Jan 13, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 13, 2025
Copy link
Contributor

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to deploy it as a RuntimeExtension!
I don't quite get why you included the go version bump here, but we sure need it at some point
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lentzi90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 14, 2025
@k8s-ci-robot k8s-ci-robot merged commit 88f5c66 into kubernetes-sigs:main Jan 14, 2025
10 checks passed
@pierreprinetti pierreprinetti deleted the orc branch January 14, 2025 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants