Apply suggestions from code review

Co-authored-by: Shane Utt <[email protected]>
Signed-off-by: Kobi Levi <[email protected]>

controllers/dataplane_controller.go

@@ -45,7 +45,7 @@ func NewDataplaneReconciler(client client.Client, schema *runtime.Scheme, manage
 		Client:                client,
 		Scheme:                schema,
 		BackendsClientManager: manager,
-		updates:               make(chan event.GenericEvent, 1000),
+		updates:               make(chan event.GenericEvent, 1),
 	}
 }
 
@@ -85,6 +85,7 @@ func (r *DataplaneReconciler) SetupWithManager(mgr ctrl.Manager) error {
 func (r *DataplaneReconciler) daemonsetHasMatchingAnnotations(obj client.Object) bool {
 	daemonset, ok := obj.(*appsv1.DaemonSet)
 	if !ok {
+		log.Error("received unexpected type in daemonset watch predicates: %T", obj)
 		return false
 	}
 

main.go

@@ -81,6 +81,7 @@ func main() {
 	clientsManager, err := client.NewBackendsClientManager(cfg)
 	if err != nil {
 		setupLog.Error(err, "unable to create backends client manager")
+		os.Exit(1)
 	}
 	defer clientsManager.Close()
 
@@ -144,7 +145,7 @@ func main() {
 }
 
 // Tee consumes the received channel and mirrors the messages into 2 new channels.
-func Tee[T any](ctx context.Context, in <-chan T) (_, _ <-chan T) {
+func tee[T any](ctx context.Context, in <-chan T) (_, _ <-chan T) {
 	out1, out2 := make(chan T), make(chan T)
 
 	OrDone := func(ctx context.Context, in <-chan T) <-chan T {