Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KubeVirt switch StorageClass config from annotation to DC #5569

Merged
merged 1 commit into from
Jan 18, 2023
Merged

KubeVirt switch StorageClass config from annotation to DC #5569

merged 1 commit into from
Jan 18, 2023

Conversation

hdurand0710
Copy link
Contributor

Signed-off-by: Helene Durand [email protected]

What this PR does / why we need it:
Last part to switch the configuration of StorageClasses to be deployed in the user (tenant) cluster from infra cluster StorageClass annotations to proper DC configuration.

Which issue(s) this PR fixes:

Fixes kubermatic/kubermatic#11689

What type of PR is this?

/kind feature

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

KubeVirt switch StorageClass config from annotation to DataCenter.

Documentation:

TBD

@hdurand0710 hdurand0710 added the sig/virtualization Denotes a PR or issue as being assigned to SIG Virtualization. label Jan 18, 2023
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. docs/tbd Denotes a PR that needs documentation (change) that will be done later. kind/feature Categorizes issue or PR as related to a new feature. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. sig/api Denotes a PR or issue as being assigned to SIG API. labels Jan 18, 2023
@hdurand0710
Copy link
Contributor Author

/hold

@kubermatic-bot kubermatic-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 18, 2023
@hdurand0710 hdurand0710 force-pushed the 11689-dc-storage-class branch from 765a045 to 92df648 Compare January 18, 2023 17:04
@kubermatic-bot kubermatic-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 18, 2023
@hdurand0710
Copy link
Contributor Author

/unhold

@kubermatic-bot kubermatic-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 18, 2023
ahmedwaleedmalik
ahmedwaleedmalik approved these changes Jan 18, 2023
View reviewed changes
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve 🦖

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 18, 2023
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 34579d2b3ad785f75d470d9105491b27008ff658

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik, hdurand0710

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 18, 2023
@kubermatic-bot kubermatic-bot merged commit 1a30562 into kubermatic:main Jan 18, 2023
@hdurand0710 hdurand0710 deleted the 11689-dc-storage-class branch January 20, 2023 07:52
@hdurand0710 hdurand0710 added this to the KKP 2.22 milestone Jan 24, 2023
@mfranczy mfranczy removed the docs/tbd Denotes a PR that needs documentation (change) that will be done later. label Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmedwaleedmalik ahmedwaleedmalik ahmedwaleedmalik approved these changes

@mfranczy mfranczy Awaiting requested review from mfranczy

@lsviben lsviben Awaiting requested review from lsviben

Assignees

@ahmedwaleedmalik ahmedwaleedmalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api Denotes a PR or issue as being assigned to SIG API. sig/virtualization Denotes a PR or issue as being assigned to SIG Virtualization. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
KKP 2.22
Development

Successfully merging this pull request may close these issues.

KubeVirt switch init of StorageClass from annotations to seed configuration
4 participants
@hdurand0710 @kubermatic-bot @ahmedwaleedmalik @mfranczy