-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
blog: learning-the-ropes-of-being-a-maintainer #124
Conversation
✅ Deploy Preview for kured ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great first post, lgtm!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great post, I like it ❤️
I like the concept! I am afraid some of it might become outdated with the code changes. I believe code structure should be in another place (contributing.md or architecture reference), and we should simply point to it. WDYT? WDYT about mentioning the rate of changes (and their releasing) and our mentality? I think mentioning "feature complete" is something important, and the rest is janitorial and/or slight inprovements. This is useful as we don't want someone proposing a complete change in the main repo, but rather small improvements, while we are open to discuss larger mindset changes for the same topic which could land in the same org and different repo. |
I agree, I think we can elaborate a bit more about the rate of changes and their size in the last months. |
I moved some of the directory structure bits to: kubereboot/kured#964 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While I am not in favour of mentioning "flame and glory" (maintaining is not glorious or doesn't attract fame), I believe that ppl reading this will get a vibe of our humourous stances, which is good enough. Let's go.
Thanks for the reviews! I'll put some more work into it. |
8fdc922
to
b506aa4
Compare
Signed-off-by: Daniel Holbach <[email protected]>
b506aa4
to
4d5b7a3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks for the blog post @dholbach !
CI issues were related to the fact the link for this new page is not yet existing, so that's fine. |
No description provided.