add argument to invert the behavior of alert-filter-regexp #786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jim Liming <[email protected]>
ckotzbauer
previously approved these changes
Aug 2, 2023
Signed-off-by: Christian Kotzbauer <[email protected]>
|
@jimliming I just pushed some small code-improvements and unit-tests to simplify things and to not ignore the |
ckotzbauer
approved these changes
Aug 14, 2023
|
makes sense - good catch on alert-firing-only |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding "--alert-filter-match-only" argument which inverts the behavior of "alert-filter-regexp". When alert-filter-match-only=true, kured will block on any active alerts that match the regexp defined in 'alert-filter-regexp'
A use case for this is:
Fire alerts if the cluster is becoming unhealthy (a % of nodes are no longer == Ready). Immediately prevent kured from continuing to drain and reboot.