Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix etjob rendering error when using local logging dir #1203

Merged

Conversation

TrafalgarZZZ
Copy link
Contributor

Purpose of this PR

Proposed changes:

  • <Change 1>
  • <Change 2>
  • <Change 3>

Change Category

  • Bugfix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that could affect existing functionality)
  • Documentation update

Rationale

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ChenYi015

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ChenYi015
Copy link
Collaborator

@TrafalgarZZZ Well done! Thanks for reporting and fixing the issue.
/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Nov 13, 2024
@google-oss-prow google-oss-prow bot merged commit a765b1c into kubeflow:master Nov 13, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants