Feat: add support for distributed serving type #1187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 31, 2024 19:12
Signed-off-by: 林联辉 <[email protected]>
Signed-off-by: 林联辉 <[email protected]>
linnlh
changed the title
linnlh
force-pushed
the
feat/distributed
branch
from
fa633fa
to
9dc8b00
Compare
Signed-off-by: 林联辉 <[email protected]>
cheyang
reviewed
Nov 7, 2024
| b.AddArgValue(key, value) | ||
| } | ||
| if err := b.PreBuild(); err != nil { | ||
| return nil, err |
There was a problem hiding this comment.
I suggest using fmt.Errorf("failed to build args: %v", err) instead of err.
cheyang
reviewed
Nov 7, 2024
| return nil, err | ||
| } | ||
| if err := b.ArgsBuilder.Build(); err != nil { | ||
| return nil, err |
|
@linnlh Please run the following commands to download the go module into the vendor package. go mod tidy
go mod vendor |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cheyang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
This PR introduces a new serving type called
distributedto Arena's serving module. The primary motivation behind these changes is to enable the deployment of large-scale models across multiple nodes within a Kubernetes (K8s) cluster.Proposed changes:
distributedto Arena's serving module which can deploy model across multiple nodes.distributedserving type.Which issue(s) this PR fixes:
Fixes #1186
Change Category
Rationale
The
distributedserving type addressed the increasing demand for multi-host inference due to the advancement of large language models (LLMs) such as Meta's Llama-3.1-405B. Currently, Arena lacks the capability to deploy models distributed across multiple nodes, and this PR aims to fill the gap.