Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily ignore rustsec warning for unmaintained instant #1636

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Conversation

clux
Copy link
Member

@clux clux commented Nov 11, 2024

Via #1635
Should ideally upgrade out the library or find a replacement, but it's not super serious. Making builds green for now.

@clux clux added the changelog-exclude changelog excluded prs label Nov 11, 2024
@clux clux added this to the 0.97.0 milestone Nov 11, 2024
@clux clux marked this pull request as ready for review November 11, 2024 00:41
@clux clux requested a review from nightkr November 11, 2024 00:41
Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.3%. Comparing base (9c402a6) to head (18bcc9a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1636   +/-   ##
=====================================
  Coverage   75.3%   75.3%           
=====================================
  Files         82      82           
  Lines       7348    7348           
=====================================
  Hits        5528    5528           
  Misses      1820    1820           

@nightkr
Copy link
Member

nightkr commented Nov 11, 2024

This should be fine, instant is a pretty trivial crate (especially if you don't care about wasm). It does mean it will trigger the same warning for downstream users though.

@clux clux merged commit 4f1e889 into main Nov 11, 2024
17 checks passed
@clux clux deleted the fix-deny branch November 11, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-exclude changelog excluded prs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants