Add proxy Body::collect_bytes for easier unit tests
#1445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoids people having to pull in `http_body_util` for the `BodyExt` Signed-off-by: clux <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1445 +/- ##
=======================================
+ Coverage 72.1% 72.1% +0.1%
=======================================
Files 78 78
Lines 6591 6592 +1
=======================================
+ Hits 4747 4748 +1
Misses 1844 1844
|
clux
changed the title
Body::collect for easier unit testsBody::collect for easier unit tests
nightkr
reviewed
Mar 26, 2024
Signed-off-by: clux <[email protected]>
clux
changed the title
Body::collect for easier unit testsBody::collect_bytes for easier unit tests
mateiidavid
approved these changes
Apr 2, 2024
Co-authored-by: Matei David <[email protected]> Signed-off-by: Eirik A <[email protected]>
Co-authored-by: Matei David <[email protected]> Signed-off-by: Eirik A <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids people having to pull in
http_body_utilfor theBodyExtTested with kube-rs/controller-rs#69 locally.