Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try out measured for metrics #71

Closed
wants to merge 2 commits into from
Closed

Try out measured for metrics #71

wants to merge 2 commits into from

Conversation

clux
Copy link
Member

@clux clux commented Jun 21, 2024

A working POC for conradludgate/measured ripping out tikv/rust-prometheus. It did take me about 3h of cranking to make everything work like before, but it's a one time cost.

PROS:

Note that the fixed cardinality stuff is not something we actually use, nor a main focus atm, as a controller benefits from dynamic labels for the objects it is reconciling and they are generally bound the cluster size anyway. But I can see it being useful for constraining error sizes down the road (the current error_label thing is very lazy and could blow up a bit under bad conditions).

CONS:

I believe opemetrics text format with exemplars could be easily retrofitted on top of measured, so maybe that's a way forward.

clux added 2 commits June 25, 2024 17:11
Signed-off-by: clux <[email protected]>

fmt

Signed-off-by: clux <[email protected]>

fix names being different from before

Signed-off-by: clux <[email protected]>

make tests work using some hacky inspection of metric

Signed-off-by: clux <[email protected]>

avoid using Vecs with fake EmptyLabels (i misunderstood the lib)

Signed-off-by: clux <[email protected]>

don't need to set label_set

Signed-off-by: clux <[email protected]>

use measured's namespace on a metric struct

Signed-off-by: clux <[email protected]>

keep main metrics struct name

Signed-off-by: clux <[email protected]>

fmt

Signed-off-by: clux <[email protected]>
@clux clux closed this Oct 10, 2024
@clux clux deleted the measured-test branch October 10, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

try out other prometheus client libraries
1 participant