Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A working POC for conradludgate/measured ripping out tikv/rust-prometheus. It did take me about 3h of cranking to make everything work like before, but it's a one time cost.
PROS:
CounterVec
ReconcileMeasurer
scope thing)Note that the fixed cardinality stuff is not something we actually use, nor a main focus atm, as a controller benefits from dynamic labels for the objects it is reconciling and they are generally bound the cluster size anyway. But I can see it being useful for constraining error sizes down the road (the current error_label thing is very lazy and could blow up a bit under bad conditions).
CONS:
lasso
frommeasured
to avoid sibling dependencies conradludgate/measured#1LabelGroup
derive re-use the user-defined struct? conradludgate/measured#3Exemplar
support conradludgate/measured#4native histogram
would be propagated (but from benchmarks the official client is also not great...)I believe opemetrics text format with exemplars could be easily retrofitted on top of
measured
, so maybe that's a way forward.