Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link Cut Tree #124

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 10 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
98 changes: 98 additions & 0 deletions content/graph/LCT.h
Original file line number Diff line number Diff line change
@@ -0,0 +1,98 @@
/**
* Author:
* Description: link-cut Tree. Supports BST-like
* augmentations. (Can be used in place of HLD).
* Current implementation supports update value at a node,
* and query max on a path.
* Tested on: http://acm.timus.ru/problem.aspx?num=1553
* Status: Passes existing fuzz tests (with function names modified).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll want to remove the old link-cut tree, so feel free to do that and modify the fuzz-test. Will also need to update the test to verify that max works (with max replaced by some non-commutative, non-associative function)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the fuzz-test to verify max for now. Will update it later for any new function that we decide on...

*/
struct Node {
bool flip = 0;
Node *pp, *p, *c[2]; // path parent, parent, children
// add stuff
int val = 0, cval = 0, ind;
Node() { pp = p = c[0] = c[1] = 0; }
void push() {
if (flip) {
rep(i, 0, 2) if(c[i]) c[i]->flip ^= 1;
swap(c[0], c[1]); flip = 0;
}
}
void pull() {
cval = val;
rep(i, 0, 2) if(c[i]) c[i]->push(), cval = max(cval, c[i]->cval);
}
void rot(bool t) {
Node *y = p, *z = y->p;
if (z) z->c[z->c[1] == y] = this;
y->c[!t] = c[t];
if (c[t]) c[t]->p = y;
c[t] = y; p = z;
y->p = this;
y->pull();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is an unreadable mess, it wouldn't hurt to golf it a bit and make it even more unreadable... some ideas:

  • !t is used more than t, maybe invert its meaning
  • , *&w = y->c[!t] at the top and use w instead of c[!t]
  • putting things on the same line is possibly worth it, if done tastefully... e.g. maybe y->p = this and p = z could go together?
  • some sort of "fix this node up" function which is called on some subset of c[!t]/this/y/z

Also, I'm a bit surprised the pull for z happens before that of y, I would have expected the other way around.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

, *&w = y->c[!t] at the top and use w instead of c[!t]

I might be misunderstanding, but why *&w instead of *w?
Also y->c[!t] is only used once, while this->c[!t] is used multiple times, so *&w = c[!t] might be better.

some sort of "fix this node up" function which is called on some subset of c[!t]/this/y/z

Like the fix function in the previous lct? (Set a node's children, and then fix will set those children's parents, but without the "(+ update sum of subtree elements etc. if wanted)" part, since that is what pull does).

Pull for z was unnecessary. (A node is only moved up one level for each call of rot, and then pulls up itself at the end of splay.) Thanks for noticing.

Everything else seems good.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, I confused y->c[!t] and c[!t]. c[!t] is assigned to, hence the &.

Like the fix function in the previous lct?

Yeah. I don't know much about how the previous lct works, but it seems like a method along those lines may be able to cut away a few lines? Again, I'm just throwing ideas out, I don't know whether it actually does save anything.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't look like adding fix will shorten it since w->p = y; is already as short as w->fix();. And then sometimes we'll have to set a parent directly anyway. (when z = 0 and we need to set this->p = z then we need to set p = z without calling z->fix() anyway). I think it's ok to leave as it is.
The other changes have been put in.

}
void xiao() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that we should probably rename this

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"propogatePathParent" is a little much though... Will keep thinking about possible alternatives.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could certainly shorten that to propPP if that's what we want to get across. But a nonsensical name would be fine as well

if (p) p->xiao(), pp = p->pp;
push();
}
void splay() {
xiao();
while (p) {
Node* y = p; Node *z = y->p;
bool t1 = (y->c[1] != this);
if (z) {
bool t2 = (z->c[1] != y);
if (t1 == t2) y->rot(t2), rot(t1);
else rot(t1), rot(t2);
} else rot(t1);
PotatoHashing marked this conversation as resolved.
Show resolved Hide resolved
}
pull();
}
Node* access() {
for (Node *y = 0, *z = this; z; y = z, z = z->pp) {
z->splay();
if (z->c[1]) z->c[1]->pp = z, z->c[1]->p = 0;
z->c[1] = y;
if (y) y->p = z;
z->pull();
}
splay();
return this;
}
Node* makeRoot() {
access()->flip ^= 1;
return this;
}
};
struct LinkCut {
vector<Node> nodes;
LinkCut(int N) : nodes(N) { rep(i, 0, N) nodes[i].ind = i; }
int findRoot(int u) {
Node *x = nodes[u].access();
while(x->c[0]) x = x->c[0];
return x->ind;
}
bool cut(int u, int v) { /// start-hash
Node *y = nodes[v].makeRoot();
Node *x = nodes[u].access();
if (x->c[0] != y || y->c[1])
return false;
x->c[0] = y->p = y->pp = 0;
x->pull();
return true;
} /// end-hash
bool isConnected(int u, int v) { return findRoot(u) == findRoot(v); }
bool link(int u, int v) {
if (isConnected(u, v)) return false;
nodes[u].makeRoot()->pp = &nodes[v];
return true;
}
void update(int u, int c) {
nodes[u].access()->val += c;
}
int query(int u, int v) { // Find max on the path from u to v.
nodes[v].makeRoot();
return nodes[u].access()->cval;
}
};
49 changes: 45 additions & 4 deletions fuzz-tests/data-structures/LinkCutTree.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,18 @@ typedef long long ll;
typedef pair<int, int> pii;
typedef vector<int> vi;

#include "../../content/graph/LinkCutTree.h"
#include "../../content/graph/LCT.h"
#include "../../content/data-structures/UnionFind.h"

bool dfs(vi &path, bitset<20> &vis, vector<set<int>> &g, int a, int &b) {
path.push_back(a);
vis[a] = 1;
if(a == b) return true;
trav(u, g[a]) if(!vis[u]) if (dfs(path, vis, g, u, b)) return true;
path.pop_back();
return false;
}

int main() {
srand(2);
LinkCut lczero(0);
Expand All @@ -21,18 +30,26 @@ int main() {
LinkCut lc(N);
UF uf(N);
vector<pii> edges;
vector<set<int>> g(N);
vector<int> val(N);
bitset<20> vis;
queue<int> q;
vi cc;
vi path;
rep(it2,0,1000) {
int v = (rand() >> 4) & 3;
int v = (rand() >> 4) & 7;
if (v == 0 && !edges.empty()) { // remove
int r = (rand() >> 4) % sz(edges);
pii ed = edges[r];
swap(edges[r], edges.back());
edges.pop_back();
g[ed.first].erase(ed.second);
g[ed.second].erase(ed.first);
if (rand() & 16)
lc.cut(ed.first, ed.second);
else
lc.cut(ed.second, ed.first);
} else {
} else if(v & 1) {
int a = (rand() >> 4) % N;
int b = (rand() >> 4) % N;
uf.e.assign(N, -1);
Expand All @@ -41,9 +58,33 @@ int main() {
if (!c && v != 1) {
lc.link(a, b);
edges.emplace_back(a, b);
g[a].emplace(b); g[b].emplace(a);
} else {
assert(lc.connected(a, b) == c);
assert(lc.isConnected(a, b) == c);
}
} else if (v & 2) {
int a = (rand() >> 4) % N;
int b = rand() % 10000;
val[a] += b;
lc.update(a, b);
} else {
int a = (rand() >> 4) % N;
vis.reset(), queue<int>().swap(q), vi().swap(cc);
q.push(a);
while(sz(q)) {
int u = q.front(); q.pop();
vis[u] = 1;
cc.push_back(u);
trav(e, g[u]) if(!vis[e]) q.push(e);
}
int r = (rand() >> 4) % sz(cc);
int b = cc[r];
vis.reset();
vi().swap(path);
assert(dfs(path, vis, g, a, b));
int mx = 0;
trav(x, path) mx = max(mx, val[x]);
assert(lc.query(a, b) == mx);
}
}
}
Expand Down