-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new vendor's ssh code #3501
Open
Yukissss
wants to merge
8
commits into
ktbyers:develop
Choose a base branch
from
Yukissss:asterfusion_contrib
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: wangyuqi <[email protected]>
Signed-off-by: wangyuqi <[email protected]>
Signed-off-by: wangyuqi <[email protected]>
Signed-off-by: wangyuqi <[email protected]>
@Yukissss Okay looks like you have some type hint failures (see linter test failure above). Could you update the PR and correct this? |
Sure, I'll correct it when I have some free time:)
…On Sat, Jan 4, 2025 at 12:37 AM Kirk Byers ***@***.***> wrote:
@Yukissss <https://github.com/Yukissss> Okay looks like you have some
type hint failures (see linter test failure above).
Could you update the PR and correct this?
—
Reply to this email directly, view it on GitHub
<#3501 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJ3MPW6MDW22LYMYW4JBWUD2I24FLAVCNFSM6AAAAABO6ITLZCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNRZGUYTGMRTHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Signed-off-by: wangyuqi <[email protected]>
I've corrected this type hint failure, and I checked it by running poetry run mypy ./netmiko. The linter check should pass then :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
I've added support for a new vendor, Asterfusion, by including the AsterfusionSSH class in our repository. Here's a summary of the updates and tests I've conducted:
New Class Addition:
Integrated the AsterfusionSSH class to enable connections and interactions with Asterfusion devices.
Testing:
All tests as outlined in the project's contribution guidelines have been performed.
Two tests encountered issues:
test_find_cfg_file failed due to directory path discrepancies on Windows. I've noted this down for further investigation.
Tests requiring genie and pyats could not be completed as these packages failed to install despite my attempts.
Thank you for considering this PR. I'm eager to contribute to the project and improve our support for Asterfusion devices.
Tests: