Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove external dependency on grep from netmiko-show #3249

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

ReK42
Copy link

@ReK42 ReK42 commented Jul 8, 2023

This PR allows netmiko-show to run cross-platform via pure Python. Tested on Windows 11 in Python 3.11 and 3.7.

Also added --write-output, which will dump the output to files in the PWD rather than printing to stdout.

Minor, non-impacting edits to other files courtesy of running black and ruff, and adding a couple things to .gitignore. All substantial edits are in netmiko/cli_tools/netmiko-show.py.

@ktbyers
Copy link
Owner

ktbyers commented Jul 8, 2023

@ReK42 Were you using the version of black specified in Netmiko's pyproject.toml. You should use exactly that version of black (otherwise the project will have too much unnecessary changes just do to minor black version changes)?

We should get rid of all of these linting changes.

I try to roll black version only at releases to minimize some of the impact of these unneeded linting changes.

@ReK42
Copy link
Author

ReK42 commented Jul 9, 2023

Reverted that commit. I had used the latest version of black from pypi.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants