Update GCS InferenceService docs #404
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tjandy98 <[email protected]>
✅ Deploy Preview for elastic-nobel-0aef7a ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: tjandy98 <[email protected]>
Signed-off-by: tjandy98 <[email protected]>
spolti
reviewed
Oct 15, 2024
spolti
reviewed
Oct 15, 2024
spolti
reviewed
Oct 15, 2024
Signed-off-by: tjandy98 <[email protected]>
Signed-off-by: tjandy98 <[email protected]>
Signed-off-by: tjandy98 <[email protected]>
Signed-off-by: tjandy98 <[email protected]>
Signed-off-by: tjandy98 <[email protected]>
Signed-off-by: tjandy98 <[email protected]>
|
/lgtm |
spolti
approved these changes
Oct 16, 2024
| "base64_service_account": "c2VydmljZWFjY291bnQ=" # base64 encoded value of the credential file | ||
| } | ||
| data: | ||
| gcloud-application-credentials.json: <base64 encoded value of the credential file> |
There was a problem hiding this comment.
It would be nice to have a note that this name can be configured using the inferenceservice-config configmap. https://github.com/kserve/kserve/blob/3deb30fee58d63e772db28abf58582570dbb28cc/config/configmap/inferenceservice.yaml#L113
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the documentation to include example of using generic secret