Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature auto wave correction #67

Merged
merged 8 commits into from
Apr 4, 2023
Merged

Conversation

krupkat
Copy link
Owner

@krupkat krupkat commented Apr 3, 2023

Major changes

  • Switch to WAVE_CORRECT_AUTO being the default (docs), previously the default was WAVE_CORRECT_HORIZ
  • Allow setting wave correction type through the GUI, calling this OpenCV method: docs, possible to turn it off completely

This is useful in case of vertical panoramas, example result before:
pano_before

After this patch:
pano_after

Example of pano with wave correction:
pano_with

Without:
pano_without

Small changes:

  • added opencv copyright notice, since added a piece of opencv code in bundle_adjuster.cc
  • marked fisheye and stereographic projections as experimental, have to do more testing with them

Advances #18

+ mark fisheye and stereographic projection types as experimental
this is needed because a piece of opencv code was added (bundle_adjuster.cc), but should have been included anyway in case of binary distributions (windows, flatpak)
@krupkat
Copy link
Owner Author

krupkat commented Apr 3, 2023

Blocked by a bug in the 22.04 runner: actions/runner-images#7373

@krupkat krupkat merged commit 1c13352 into main Apr 4, 2023
@krupkat krupkat deleted the feature-autodetect-vertical-pano branch April 4, 2023 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant