-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for getting optional information about openshift cluster version. #137
Fix for getting optional information about openshift cluster version. #137
Conversation
Can one of the admins verify this patch? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/rerun all |
|
The CI needs to be updated to be 120 characters not 110. Will be fixed in PR LGTM |
@ratsuf we might want to rebase the PR. |
1672b36
to
0c67f0f
Compare
@chaitanyaenr I've rebased the PR. |
0c67f0f
to
66d61f9
Compare
@chaitanyaenr should I change something else? |
/rerun all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Description
In the case of openshift distribution, there is an invocation of
kubectl get clusterversion
. But such a type of resource not present in OKD 3.11 and lower. As a result - #133Because the result of 'clusterversion' used just for reference in the logs, I suggest the following fixes:
Fixes
optional_invoke
method because currentinvoke
stops Cerberus execution with UnboundLocalError in case of exception.