Update start_cerberus.py #135
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solving oc issue
|
Can one of the admins verify this patch? |
chaitanyaenr
reviewed
May 6, 2021
| logging.info("\n%s" % (cluster_version)) | ||
| cluster_info = runcommand.invoke("kubectl cluster-info | awk 'NR==1' | sed -r " | ||
| cluster_info = runcommand.invoke("oc cluster-info | awk 'NR==1' | sed " |
There was a problem hiding this comment.
@seanogor we might want to use kubectl here since cluster-info resource is common to both kubernetes as well openshift distributions. This way it works even when the distribution is set to kubernetes. Thoughts?
|
/rerun all |
|
|
Im happy with that, was only changing for consistency... kubectl on the
second command is fine
…On Thu, 6 May 2021, 22:33 Naga Ravi Chaitanya Elluri, < ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In start_cerberus.py
<#135 (comment)>
:
> logging.info("\n%s" % (cluster_version))
- cluster_info = runcommand.invoke("kubectl cluster-info | awk 'NR==1' | sed -r "
+ cluster_info = runcommand.invoke("oc cluster-info | awk 'NR==1' | sed "
@seanogor <https://github.com/seanogor> we might want to use kubectl here
since cluster-info resource is common to both kubernetes as well openshift
distributions. This way it works even when the distribution is set to
kubernetes. Thoughts?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#135 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB74KG2ZH2SRRKA5NTUZ6CTTMMDMBANCNFSM44HU5I2Q>
.
|
|
Taking out the -r option didn't work for me. I'm also on a mac |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solving oc issue
Description
#133
Fixes
dropped in oc, removed -r option in sed as it didn't work on a mac but that can be put back in if necessary