Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: LoadProfileBottomSheet accessing disposed outerContext #645

Merged
merged 1 commit into from
Nov 5, 2023

Conversation

aryanA101a
Copy link
Contributor

fixes #644

The following code is causing the issue:
It only pops UserBottomSheet, and leaves the LoadProfileBottomSheet to access the stale outerContext even after navigation is done.

case UserBottomSheetAction.message:
        //more code
        widget.outerContext.go('/rooms/${roomIdResult.result!}');
        Navigator.of(context, rootNavigator: false).pop();
        break;

@krille-chan
Copy link
Owner

Thank you very much <3

@krille-chan
Copy link
Owner

Formatting is broken. Please run dart format lib/ test/ and update the PR to fix it.

auto-merge was automatically disabled November 4, 2023 19:04

Head branch was pushed to by a user without write access

@krille-chan krille-chan merged commit ab12ada into krille-chan:main Nov 5, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bottomSheet is not properly popped
2 participants