Diff nil and empty for slice and map #42

motomux · 2016-12-09T20:59:39Z

cespare · 2016-12-20T01:07:58Z

This would be a nice improvement. If you're using pretty.Diff as part of a test failure message, it can be kind of mysterious why the diff is empty even though reflect.DeepEqual returns false.

@kr any reason not to merge? The change LGTM.

jaytaylor · 2017-03-27T21:37:20Z

+1

I'd also like to see this merged!

- Use the branch of pretty with this feature fixed: kr/pretty#42 - Add the Limit to the resources declaration to avoid dummy differences between statefulsets (where both Resource structures are empty, but in one case the fields are not mentioned, while in another they are assigned to empty values).

tbg · 2019-07-09T08:23:09Z

For anyone else wanting this, your best bet is probably to just switch to @motomux' fork at https://github.com/motomux/pretty.

- Use the branch of pretty with this feature fixed: kr/pretty#42 - Add the Limit to the resources declaration to avoid dummy differences between statefulsets (where both Resource structures are empty, but in one case the fields are not mentioned, while in another they are assigned to empty values).

Diff nil and empty for slice and map

b2aad2c

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Diff nil and empty for slice and map #42

Diff nil and empty for slice and map #42

motomux commented Dec 9, 2016

cespare commented Dec 20, 2016

jaytaylor commented Mar 27, 2017

tbg commented Jul 9, 2019

Diff nil and empty for slice and map #42

Are you sure you want to change the base?

Diff nil and empty for slice and map #42

Conversation

motomux commented Dec 9, 2016

cespare commented Dec 20, 2016

jaytaylor commented Mar 27, 2017

tbg commented Jul 9, 2019