Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/spreadsheet unknown columns #137

Merged
merged 4 commits into from
Sep 13, 2023

Conversation

MartinKl
Copy link
Collaborator

@MartinKl MartinKl commented Sep 13, 2023

An attribute can now be set for how to handle columns, that are not mentioned in the column map. Options are:

  1. ignore (default, matches current behaviour, compatible with existing toml files)
  2. fallback tokenization (String value)
  3. only map to timeline tokens (empty namespace)

fixes #136

@barecheck
Copy link

barecheck bot commented Sep 13, 2023

Barecheck - Code coverage report

Total: 86.41%

Your code coverage diff: 0.03% ▴

Uncovered files and lines
FileLines
src/importer/spreadsheet.rs25, 33-35, 74, 90-97, 110, 126-133, 146, 162, 289, 405, 417-418, 427-428, 489-490, 499-500, 509-510, 519-520, 529-530

@MartinKl MartinKl added this pull request to the merge queue Sep 13, 2023
Merged via the queue into main with commit 052d059 Sep 13, 2023
4 checks passed
@MartinKl MartinKl deleted the feature/spreadsheet-unknown-columns branch September 13, 2023 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spreadsheets: How to deal with non-mentioned columns or no column map
1 participant